Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concat() function and add createArray() function #322

Merged
merged 3 commits into from Feb 23, 2024
Merged

Fix concat() function and add createArray() function #322

merged 3 commits into from Feb 23, 2024

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

  • Fix concat() to align with ARM: only accept string and arrays, error if mixed types. This required changing a bunch of tests that used numbers.
  • Add createArray() to test with concat()
  • Change functions to accept and return Value directly thus removing some unnecessary structs used previously
  • Echo resource now supports int, bool, string, and arrays so changed property to output instead of text and updated tests

PR Context

Fix #271

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Feb 23, 2024
Merged via the queue into PowerShell:main with commit 07c646e Feb 23, 2024
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the concat-array branch February 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmenaga anmenaga anmenaga approved these changes

@tgauth tgauth Awaiting requested review from tgauth

Assignees
No one assigned
Labels
Doc-Impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The DSC concat() function behaves differently than the ARM concat() function
2 participants
@SteveL-MSFT @anmenaga