Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

New-DscSelfSignedCertificate: Update informational messages #259

Closed
johlju opened this issue Jul 24, 2018 · 1 comment
Closed

New-DscSelfSignedCertificate: Update informational messages #259

johlju opened this issue Jul 24, 2018 · 1 comment
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Contributor

johlju commented Jul 24, 2018

In Appveyor.psm1 there is a line that write the information below. Maybe we should copy that line into the New-DscSelfSignedCertificate function instead, that actually creates the certificate.

Write-Info -Message ('Created self-signed certificate ''{0}'' ...

And in the Appveyor.psm1 changed the line to

Write-Info -Message ('Using self-signed certificate ''{0}'' ...

The it won't look like the certificate is created twice, when it actually is only created the first time New-DscSelfSignedCertificate is called.
https://ci.appveyor.com/project/PlagueHO/activedirectorycsdsc/build/1.1.49.0#L17
@johlju johlju changed the title New-DscSelfSignedCertificate: Update informational messages. New-DscSelfSignedCertificate: Update informational messages Jul 24, 2018
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jul 24, 2018
@PlagueHO
Copy link
Collaborator

I'll get this done! Leave it with me.

@PlagueHO PlagueHO mentioned this issue Jul 25, 2018
Merged
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johlju @PlagueHO