Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS v6 approved verb highlighting #147

Closed
Akaizoku opened this issue Sep 26, 2018 · 4 comments
Closed

PS v6 approved verb highlighting #147

Akaizoku opened this issue Sep 26, 2018 · 4 comments

Comments

@Akaizoku
Copy link

Akaizoku commented Sep 26, 2018

The list of approved verb has been updated in PowerShell v6 to include the following verbs:

Verb (alias) Action Comments
Build (bd) Creates an artifact (usually a binary or document) out of some set of input files (usually source code or declarative documents) This verb was added in PowerShell v6
Deploy(dp) Sends an application, website, or solution to a remote target[s] in such a way that a consumer of that solution can access it after deployment is complete This verb was added in PowerShell v6

Could it be possible to add highlighting for those new verbs?

$foo = Build-Foo
$foo = Deploy-Foo
$foo = Get-Foo
@TylerLeonhardt
Copy link
Member

@Akaizoku those verbs should have syntax highlighting (see my addition to your question). Are you seeing otherwise? If so, can you share a screenshot or something?

@Akaizoku
Copy link
Author

Akaizoku commented Oct 1, 2018

@tylerl0706 I can see it properly highlighted here, but not on Atom which is using the language-powershell package.

On the package repository it is written:

If you discover any issues with the way the syntax is highlighted, please open an issue against the PowerShell/EditorSyntax repository instead of this one, since this package is based on that grammar.

This is the reason I opened the issue here.

@TylerLeonhardt
Copy link
Member

Since that's the case, you should open an issue on that project and let them know that they need to update to the latest version of this grammar. Since we fixed this issue already.

I'm guessing that all they will need to do is snap a new release with the updated grammar.

Unfortunately, we have no control of that project to update it.

@TylerLeonhardt
Copy link
Member

it's cool to see a community member working on Atom support 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants