Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YA Regex that breaks syntax highlighting #75

Closed
lipkau opened this issue Apr 10, 2018 · 3 comments
Closed

YA Regex that breaks syntax highlighting #75

lipkau opened this issue Apr 10, 2018 · 3 comments

Comments

@lipkau
Copy link

lipkau commented Apr 10, 2018

Description

I have the following line of code in my script:

[ValidatePattern('(?=^.{1,254}$)(^(?:(?!\d+\.)[a-zA-Z0-9_\-]{1,63}\.?)+(?:[a-zA-Z]{2,})$)')]

Here is how it looks in VSCode:

image

Environment

PS C:\> code -v
1.22.1
950b8b0d37a9b7061b6f0d291837ccc4015f5ecdx64

PS C:\> $pseditor.EditorServicesVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
1      6      0      0

PS C:\> code --list-extensions --show-versions
[...]
ms-vscode.PowerShell@1.6.0
[...]

PS C:\> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.1
PSEdition                      Core
GitCommitId                    v6.0.1
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@omniomi
Copy link
Collaborator

omniomi commented May 3, 2018

I managed to find the issue. Need to do some more testing to make sure the fix doesn't introduce new problems and then I will submit the PR.

regex-fix

@TylerLeonhardt
Copy link
Member

Niceee 👍

@omniomi omniomi mentioned this issue May 10, 2018
@omniomi
Copy link
Collaborator

omniomi commented May 21, 2018

Fixed by #94

@omniomi omniomi closed this as completed May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants