Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DefaultTokenColor to 39m instead of 37m #3702

Open
1 task done
SteveL-MSFT opened this issue May 30, 2023 · 1 comment
Open
1 task done

Set DefaultTokenColor to 39m instead of 37m #3702

SteveL-MSFT opened this issue May 30, 2023 · 1 comment
Assignees
@StevenBucher98
Labels
Issue-Enhancement It's a feature request.

Comments

@SteveL-MSFT
Copy link
Member

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

Currently, the DefaultTokenColor is 37m which is white. However, when used with a light theme, that text is invisible. It would be better to use 39m which sets it to the terminals default color which would automatically adjust for light and dark themes. We should validate that popular terminals handle 39m as we expect before making the change (try light and dark themes).

Proposed technical implementation details (optional)

No response
@SteveL-MSFT SteveL-MSFT added the Issue-Enhancement It's a feature request. label May 30, 2023
@ghost ghost added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label May 30, 2023
@DHowett
Copy link
Contributor

DHowett commented May 30, 2023

Prior notes here! MicrosoftDocs/PowerShell-Docs#9358 (comment)

@StevenBucher98 StevenBucher98 self-assigned this Jun 5, 2023
@StevenBucher98 StevenBucher98 removed the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StevenBucher98 StevenBucher98

Labels
Issue-Enhancement It's a feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DHowett @SteveL-MSFT @StevenBucher98