Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC0000-RFC-Process.md comments #5

Closed
SteveL-MSFT opened this issue Nov 30, 2015 · 8 comments
Closed

RFC0000-RFC-Process.md comments #5

SteveL-MSFT opened this issue Nov 30, 2015 · 8 comments
Assignees

Comments

@SteveL-MSFT
Copy link
Member

Leave feedback on the process document here

@aL3891
Copy link

aL3891 commented Dec 3, 2015

I really like that you're looking for comments on the powershell language but wouldn't be easier to use git issues directly instead of going through these md files for each language feature?

@smurawski
Copy link

I actually think (and I'm biased because I like how the Chef RFCs work) that using a pull request to track draft RFC is a good thing. It makes it easier to comment on specific portions of the RFC and keeps the discussion scoped there.

@SteveL-MSFT
Copy link
Member Author

Thanks for the feedback. We considered using Git Pull Request and thought it was too complicated. We will revisit that decision.

@smurawski
Copy link

@SteveL-MSFT I think PRs would be less complicated than bouncing between directories and issues, but I live in GitHub for a good chunk of my day. 😄

@SteveL-MSFT
Copy link
Member Author

We discussed this internally and appreciate the feedback. At this point, we're going to stick with the current process to get some more data and we're open to re-evaluating this in the future as we have more RFCs and get more feedback. Thanks!

@aL3891
Copy link

aL3891 commented Dec 16, 2015

The line comments is a fair point :)

@maethorechannen
Copy link

maethorechannen commented Aug 23, 2016

No where in the process document does it actually state how to comment on an RFC. I'm assuming it's by commenting on issues here on GitHib, but that's an assumption (the commenting could be somewhere else) and even if my assumption is correct, someone new to GitHub might not know that commenting on issues is a thing you can do.

@SteveL-MSFT
Copy link
Member Author

@maethorechannen good catch, will get the that added

@SteveL-MSFT SteveL-MSFT self-assigned this Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants