Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHubRepositories: Add Dependabot Service Functions #235

Merged
merged 6 commits into from
Jun 24, 2020
Merged

GitHubRepositories: Add Dependabot Service Functions #235

merged 6 commits into from
Jun 24, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 13, 2020 •
edited by HowardWolosky

Description

This PR adds the following functions to the GitHubRepositories module to manage the GitHub Dependabot services.

  • Test-GitHubRepositoryVulnerabilityAlert
  • Enable-GitHubRepositoryVulnerabilityAlert
  • Disable-GitHubRepositoryVulnerabilityAlert
  • Enable-GitHubRepositorySecurityFix
  • Disable-GitHubRepositorySecurityFix

There is no Test-GitHubRepositorySecurityFix function is there is currently no API for this.

Issues Fixed

None

References

GitHub Repositories Rest API v3

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-Guardian
Copy link
Contributor Author

Can we trigger the CI for this PR?

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian
Copy link
Contributor Author

Can we trigger the CI for this PR?

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian X-Guardian marked this pull request as ready for review June 14, 2020 18:37
@HowardWolosky HowardWolosky added api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/ enhancement An issue or pull request introducing new functionality to the project. api completeness This is basic API functionality that hasn't been implemented yet. and removed enhancement An issue or pull request introducing new functionality to the project. labels Jun 18, 2020
HowardWolosky
HowardWolosky requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Some feedback for you to consider. Adding in the missing pipeline support is the primary missing work needed right now.

Thanks again.

GitHubRepositories.ps1 Outdated Show resolved Hide resolved
GitHubRepositories.ps1 Outdated Show resolved Hide resolved
GitHubRepositories.ps1 Show resolved Hide resolved
GitHubRepositories.ps1 Show resolved Hide resolved
GitHubRepositories.ps1 Show resolved Hide resolved
GitHubRepositories.ps1 Outdated Show resolved Hide resolved
GitHubRepositories.ps1 Outdated Show resolved Hide resolved
GitHubRepositories.ps1 Outdated Show resolved Hide resolved
GitHubRepositories.ps1 Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
HowardWolosky
HowardWolosky requested changes Jun 20, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update. Looks like there are still a few things to resolve here, along with our disagreement on the behavior of failures within the Test-* method.

GitHubRepositories.ps1 Outdated Show resolved Hide resolved
GitHubRepositories.ps1 Outdated Show resolved Hide resolved
Tests/GitHubRepositories.tests.ps1 Show resolved Hide resolved
GitHubRepositories.ps1 Show resolved Hide resolved
GitHubRepositories.ps1 Show resolved Hide resolved
@HowardWolosky
Copy link
Member

@X-Guardian - please be sure to @ mention me once this is ready for the next review (there are so many of your reviews for me to keep track of). Thanks again for all your work. Much appreciated!

@HowardWolosky HowardWolosky added the waiting for update Waiting for an update to the PR before the next review label Jun 20, 2020
@X-Guardian X-Guardian mentioned this pull request Jun 21, 2020
Merged
@X-Guardian
Copy link
Contributor Author

@HowardWolosky please trigger the CI for this PR.

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky removed the waiting for update Waiting for an update to the PR before the next review label Jun 24, 2020
@HowardWolosky HowardWolosky merged commit b70c7d4 into microsoft:master Jun 24, 2020
@X-Guardian X-Guardian deleted the GitHubRepositories-Dependabot branch June 28, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky approved these changes

Assignees
No one assigned
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@X-Guardian @HowardWolosky