Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHubContents: New Function Set-GitHubContent #241

Merged
merged 10 commits into from
Jun 27, 2020
Merged

GitHubContents: New Function Set-GitHubContent #241

merged 10 commits into from
Jun 27, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 16, 2020 •
edited

Description

This PR adds the following new function to the GitHubContents module:

  • Set-GitHubContent

An additional parameter BranchName has also been added to the Get-GitHubContent function which is required by Set-GitHubContent.

Issues Fixed

None

References

GitHub Rest API v3 Contents

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-Guardian
Copy link
Contributor Author

Can we trigger the CI for this PR?

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@HowardWolosky HowardWolosky added enhancement An issue or pull request introducing new functionality to the project. api-contents Work to complete the API's defined here: https://developer.github.com/v3/repos/contents api completeness This is basic API functionality that hasn't been implemented yet. and removed enhancement An issue or pull request introducing new functionality to the project. labels Jun 18, 2020
HowardWolosky
HowardWolosky requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, a stellar and much appreciated addition to the module. Thanks so much!

I have some feedback for you to consider (along with the need to update for pipeline support) before we can get this merged in.

Really -- great work here.

Tests/GitHubContents.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Outdated Show resolved Hide resolved
GitHubContents.ps1 Show resolved Hide resolved
GitHubContents.ps1 Show resolved Hide resolved
GitHubContents.ps1 Show resolved Hide resolved
GitHubContents.ps1 Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Show resolved Hide resolved
HowardWolosky
HowardWolosky reviewed Jun 20, 2020
View reviewed changes
GitHubContents.ps1 Outdated Show resolved Hide resolved
@HowardWolosky
Copy link
Member

@X-Guardian - please be sure to @ mention me once this is ready for the next review. Thanks again for all your work. Much appreciated!

@HowardWolosky HowardWolosky added the waiting for update Waiting for an update to the PR before the next review label Jun 20, 2020
@X-Guardian X-Guardian marked this pull request as ready for review June 21, 2020 19:05
@X-Guardian
Copy link
Contributor Author

Can we trigger the CI for this PR?

HowardWolosky
HowardWolosky requested changes Jun 21, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional minor changes needed, along with fixing (and testing) pipeline support.

Looking forward to having this...thanks!

GitHubContents.ps1 Outdated Show resolved Hide resolved
GitHubContents.ps1 Outdated Show resolved Hide resolved
GitHubContents.ps1 Outdated Show resolved Hide resolved
GitHubContents.ps1 Outdated Show resolved Hide resolved
GitHubContents.ps1 Outdated Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Show resolved Hide resolved
@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

HowardWolosky
HowardWolosky requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple lingering issues.

GitHubContents.ps1 Show resolved Hide resolved
GitHubContents.ps1 Show resolved Hide resolved
Tests/GitHubContents.tests.ps1 Show resolved Hide resolved
@HowardWolosky HowardWolosky mentioned this pull request Jun 25, 2020
Open
@X-Guardian
Copy link
Contributor Author

@HowardWolosky, can we trigger the CI for this PR?

@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian
Copy link
Contributor Author

Ok @HowardWolosky, ready for next review.

HowardWolosky
HowardWolosky previously approved these changes Jun 27, 2020
View reviewed changes
GitHubContents.ps1 Outdated Show resolved Hide resolved
@HowardWolosky HowardWolosky dismissed stale reviews from themself via 10be485 June 27, 2020 21:38
@HowardWolosky HowardWolosky removed the waiting for update Waiting for an update to the PR before the next review label Jun 27, 2020
@HowardWolosky HowardWolosky merged commit a1f5e93 into microsoft:master Jun 27, 2020
@X-Guardian X-Guardian deleted the GitHubContents-Set-GitHubContent branch June 28, 2020 00:09
@X-Guardian X-Guardian mentioned this pull request Jun 29, 2020
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky left review comments

Assignees
No one assigned
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-contents Work to complete the API's defined here: https://developer.github.com/v3/repos/contents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@X-Guardian @HowardWolosky