Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New GitHubRepositoryBranchProtectionRule Functions #255

Merged
merged 15 commits into from
Jul 31, 2020
Merged

New GitHubRepositoryBranchProtectionRule Functions #255

merged 15 commits into from
Jul 31, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 29, 2020 •
edited
Loading

Description

This PR adds the following GitHub Branch Protection Rule functions to the GitHubBranches module:

  • Get-GitHubRepositoryBranchProtectionRule
  • New-GitHubRepositoryBranchProtectionRule
  • Remove-GitHubRepositoryBranchProtectionRule

The lukeCageAcceptHeader was also added to the GitHubCore module with a value of application/vnd.github.luke-cage-preview+json.

Issues Fixed

None

References

GitHub REST API v3

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-Guardian X-Guardian mentioned this pull request Jun 29, 2020
Closed
8 tasks
@HowardWolosky HowardWolosky added api completeness This is basic API functionality that hasn't been implemented yet. api-repositories-branches Work to complete the API's defined here: https://developer.github.com/v3/repos/branches/ labels Jun 29, 2020
@X-Guardian X-Guardian force-pushed the GitHubRepositoryBranchProtection branch from a869092 to cdc1cdb Compare June 29, 2020 16:53
HowardWolosky
HowardWolosky requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still have some unresolved thoughts from the previous version of this PR that we can continue here.

GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubCore.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Show resolved Hide resolved
@HowardWolosky HowardWolosky added the waiting for update Waiting for an update to the PR before the next review label Jul 2, 2020
@X-Guardian X-Guardian force-pushed the GitHubRepositoryBranchProtection branch from 9e3a85b to 794a8bb Compare July 17, 2020 20:48
@X-Guardian X-Guardian marked this pull request as ready for review July 17, 2020 21:08
@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@X-Guardian
Copy link
Contributor Author

@HowardWolosky, this is ready for the next review.

@X-Guardian X-Guardian force-pushed the GitHubRepositoryBranchProtection branch from 8b329b0 to b6bb240 Compare July 21, 2020 16:56
@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

HowardWolosky
HowardWolosky requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this New instead of Set certainly simplified this substantially.
Just a couple small observations and this should be good to merge.
Thanks!

GitHubBranches.ps1 Outdated Show resolved Hide resolved
GitHubBranches.ps1 Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
Tests/GitHubBranches.tests.ps1 Outdated Show resolved Hide resolved
@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky removed the waiting for update Waiting for an update to the PR before the next review label Jul 31, 2020
@HowardWolosky HowardWolosky merged commit 981b85c into microsoft:master Jul 31, 2020
@X-Guardian X-Guardian deleted the GitHubRepositoryBranchProtection branch April 19, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardWolosky HowardWolosky HowardWolosky requested changes

Assignees
No one assigned
Labels
api completeness This is basic API functionality that hasn't been implemented yet. api-repositories-branches Work to complete the API's defined here: https://developer.github.com/v3/repos/branches/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@X-Guardian @HowardWolosky