Fix coalesced Team permission property #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving the permissions granted to a team for a repository, the API returns an array of booleans indicating what individual permissions the team currently has. | name | permissions granted | | ---- | ------------------ | | pull | pull | | triage | pull, triage | | push | pull, triage, push | | maintain | pull, triage, push, maintain | | admin | pull, triage, push, maintain, admin | As you can see, each permissions builds on top of the previous permission. When adding extra properties to this returned object via `Add-GitHubRepositoryTeamPermissionAdditionalProperties`, we also add a new `permission` property that attempts to represent the collection of permissions with their current top-permission level. The logic however incorrectly favored `push` over `maintain` and thus would always said that a Team had `push` permission when in fact it may have actually had `maintain` permission. This simple change corrects that ordering mistake.
HowardWolosky
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When retrieving the permissions granted to a team for a repository, the API returns an array of booleans indicating what individual permissions the team currently has.
As you can see, each permissions builds on top of the previous
permission. When adding extra properties to this returned object
via
Add-GitHubRepositoryTeamPermissionAdditionalProperties, wealso add a new
permissionproperty that attempts to represent thecollection of permissions with their current top-permission level.
The logic however incorrectly favored
pushovermaintainand thuswould always said that a Team had
pushpermission when in fact itmay have actually had
maintainpermission.This simple change corrects that ordering mistake.
Issues Fixed
Fixes #360
References
Check team permissions for a repository
Checklist
Comment-based help added/updated, including examples.Formatters were created for any new types being added.New/changed code continues to support the pipeline.Changes to the manifest file follow the manifest guidance.Relevant usage examples have been added/updated in USAGE.md.If desired, ensure your name is added to our Contributors list