Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/Set-GitHubRepository: Add AllowAutoMerge Parameter #383

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jan 10, 2023

Description

This PR adds the AllowAutoMerge parameter to the New-GitHubRepository and Set-GitHubRepository functions:

Note: this feature is currently only supported by GitHub on public repositories.

Issues Fixed

References

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@X-Guardian X-Guardian changed the title Initial Commit New/Set-GitHubRepository: Add AllowAutoMerge Parameter Jan 10, 2023
@X-Guardian
Copy link
Contributor Author

@HowardWolosky, this PR is ready for review.

@X-Guardian
Copy link
Contributor Author

@HowardWolosky, any timescale on when you are going to be able to review my open PRs? 5 of the 6 are very simple updates.

@variableresistor
Copy link
Contributor

@HowardWolosky, any timescale on when you are going to be able to review my open PRs? 5 of the 6 are very simple updates.

My question as well... Guess they've been busy at work. The bot won't close our PRs out, will it?

@HowardWolosky
Copy link
Member

@HowardWolosky, any timescale on when you are going to be able to review my open PRs? 5 of the 6 are very simple updates.

I appreciate your patience here. Lost track that these were out for review. Will aim to get most of them done by the end of the coming weekend.

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. I think this just needs doc comment updates.

GitHubRepositories.ps1 Show resolved Hide resolved
GitHubRepositories.ps1 Show resolved Hide resolved
@HowardWolosky
Copy link
Member

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@HowardWolosky HowardWolosky merged commit b976e95 into microsoft:master Feb 27, 2023
@X-Guardian X-Guardian deleted the AllowAutoMerge branch April 19, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New/Set-GitHubRepository: Add Support for Allow Auto Merge Option
3 participants