Improve robustness of Get-NugetPackageDllPath to file access issues
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Test-Path` will write to the error stream if there is a file access issue, but still return back `$false`. Within this method, we simply want to test if the file exists -- not having access to the file is an equivalence case for us and should be silent. This updates `Test-Path` to use `-ErrorAction Ignore` to silence any potential errors that we don't care about. Additionally this updates `Test-AssemblyIsDesiredVersion` to also be robust to file access issues. If it has issues getting the file information, even after getting passed the `Test-Path` in the parameter validation, we want to gracefully return `$false` without undo error logging (we will write a Warning log entry though for completeness).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-Pathwill write to the error stream if there is a file access issue,but still return back
$false. Within this method, we simply want to testif the file exists -- not having access to the file is an equivalence case
for us and should be silent.
This updates
Test-Pathto use-ErrorAction Ignoreto silence any potentialerrors that we don't care about.
Additionally this updates
Test-AssemblyIsDesiredVersionto also be robustto file access issues. If it has issues getting the file information, even
after getting passed the
Test-Pathin the parameter validation, we want togracefully return
$falsewithout undo error logging (we will write aWarning log entry though for completeness).