AzureEnvironmentBuilder: VM max name length and fix for Azure PowerShell 6.0.0 #890
Conversation
Shortened VM names as max limit is 15 characters
Codecov Report
@@ Coverage Diff @@
## dev #890 +/- ##
=====================================
Coverage 91% 91%
=====================================
Files 113 113
Lines 11112 11112
Branches 1 1
=====================================
Hits 10177 10177
Misses 934 934
Partials 1 1 |
|
@jensotto there was other PR's merged into dev, so your working branch is out of date compared to dev. Could you please rebase against branch dev using |
johlju
added
the
waiting for code fix
|
@johlju done |
There was a problem hiding this comment.
One small comment
FYI: These templates are used for the integration tests. These were added a while back, but never implemented because we couldn't find a good way of implementing these tests in an automated fashion.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jensotto and @ykuijs)
Tests/Integration/Azure/AzureEnvironmentBuilder.psm1, line 134 at r1 (raw file):
# Get keys for software storage $storageAccount = Get-AzureRmResource -ResourceName $SoftwareStorageAccountName
Does this cmdlet also exists in pre-v6.0?
Since SharePoint requires Windows PowerShell, we cannot assume that everybody is using PS6. So if this cmdlet doesn't exist in PS5.1, we should implement a check.
There was a problem hiding this comment.
I was just following the Wiki page Creating an Azure development environment to set up a new development environment in Azure. I have several Hyper-V environments on my laptop, but wanted to set it up on Azure. I never intended to use it for integration tests.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jensotto)
Tests/Integration/Azure/AzureEnvironmentBuilder.psm1, line 134 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
Does this cmdlet also exists in pre-v6.0?
Since SharePoint requires Windows PowerShell, we cannot assume that everybody is using PS6. So if this cmdlet doesn't exist in PS5.1, we should implement a check.
It is not a cmdlet in PS5.1 or PS6 it is a cmdlet in Azure PowerShell 6.0.0. It has nothing to do with SharePoint and the instructions on the Wiki page for installing Azure PowerShell installs the lates version of Azure PowerShell.
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ykuijs)
Tests/Integration/Azure/AzureEnvironmentBuilder.psm1, line 134 at r1 (raw file):
Previously, jensotto (Jens Otto Hatlevold) wrote…
It is not a cmdlet in PS5.1 or PS6 it is a cmdlet in Azure PowerShell 6.0.0. It has nothing to do with SharePoint and the instructions on the Wiki page for installing Azure PowerShell installs the lates version of Azure PowerShell.
Done.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Tests/Integration/Azure/AzureEnvironmentBuilder.psm1, line 134 at r1 (raw file):
Previously, jensotto (Jens Otto Hatlevold) wrote…
Done.
Ok perfect, when I read 6.0 I automatically assume PS6.0.....my bad ;-)
johlju
removed
the
waiting for code fix
Pull Request (PR) description
Virtual Machines can have names of maximum 15 characters. Previously the VM name was concatenated using the resource group name and a postfix of up to 4 characters. This would leave only 11 characters for the resource group name which would only fail upon VM creation. Now the VMs have a fixed name (VM-dc/VM-sql/VM-sp)
Changed Find-AzureRmResource to Get-AzureRmResource as Find-AzureRmResource has been removed in Azure PowerShell 6.0.0
https://github.com/Azure/azure-powershell/releases/tag/v6.0.0-May2018
"Merge Get- and Find- functionality in Get-AzureRmResource"
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is