Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178

Closed
johlju opened this issue Jul 6, 2018 · 0 comments · Fixed by #1608
Closed

SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178

johlju opened this issue Jul 6, 2018 · 0 comments · Fixed by #1608
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 6, 2018

Details of the scenario you tried and the problem that is occurring

The helper function is duplicated between the resources SqlSetup and SqlWindowsFirewall. This should be moved to the helper module instead, to be a common helper function.
Maybe the function should be renamed to Get-SqlPathMajorVersion or similar.

https://github.com/PowerShell/SqlServerDsc/blob/6328f40f7121131f72ee62fdf6470f5ed569953e/DSCResources/MSFT_SqlWindowsFirewall/MSFT_SqlWindowsFirewall.psm1#L793-L804

The DSC configuration that is using the resource (as detailed as possible)

n/a

Version of the operating system and PowerShell the target node is running

n/a

SQL Server edition and version the target node is running

n/a

What SQL Server PowerShell modules, and which version, are present on the target node.

n /a

Version of the DSC module you're using, or write 'dev' if you're using current dev branch

Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jul 6, 2018
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 11, 2020
@johlju johlju mentioned this issue Aug 11, 2020
Merged
9 tasks
johlju added a commit that referenced this issue Aug 11, 2020
@johlju
SqlSetup,SqlWindowsFirewall: Fix duplicate function (#1608)
877ea96 
- SqlServerDsc
  - Document changes in the file `build.yml`.
- SqlSetup
  - Duplicate function Get-SqlMajorVersion was removed and instead the
    helper function Get-FilePathMajorVersion from the helper module
    SqlServerDsc.Common is used (issue #1178).
- SqlWindowsFirewall
  - Duplicate function Get-SqlMajorVersion was removed and instead the
    helper function Get-FilePathMajorVersio` from the helper module
    SqlServerDsc.Common is used (issue #1178).
- SqlServerDsc.Common
  - Function Get-FilePathMajorVersion was added. The function Get-SqlMajorVersion
    from the resources SqlSetup and SqlWindowsFirewall was moved and
    renamed without any functional changes (issue #1178).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlSetup,SqlWindowsFirewall: Fix duplicate function johlju/SqlServerDsc
1 participant
@johlju