Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine DscResource.LocalizationHelper and DscResource.Common into SqlServerDsc.Common #1357

Closed
johlju opened this issue May 4, 2019 · 0 comments · Fixed by #1366
Closed

Combine DscResource.LocalizationHelper and DscResource.Common into SqlServerDsc.Common #1357

johlju opened this issue May 4, 2019 · 0 comments · Fixed by #1366
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented May 4, 2019

We should combine the helper modules DscResource.LocalizationHelper and DscResource.Common into SqlServerDsc.Common.

We also need to name the new module SqlServerDsc.Common so it does not conflict with another resource modules helper module if both would be using a generic name.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels May 4, 2019
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels May 28, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 28, 2019
@johlju
Changes to SqlServerDsc
998825c 
- Combine DscResource.LocalizationHelper and DscResource.Common into
  SqlServerDsc.Common (issue dsccommunity#1357).
@johlju johlju mentioned this issue May 28, 2019
Merged
9 tasks
johlju added a commit that referenced this issue May 30, 2019
@johlju
SqlServerDsc: Opt-in for 'Common Test - Validate Localization' (#1366)
2ed912f 
- Changes to SqlServerDsc
  - Opt-in to the common test 'Common Test - Validation Localization'.
  - Removed the helper function `New-TerminatingError`, `New-WarningMessage`
    and `New-VerboseMessage` in favor of the the new
    [localization helper functions](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#localization).
  - Combine DscResource.LocalizationHelper and DscResource.Common into
    SqlServerDsc.Common (issue #1357).
- Changes to SqlAlwaysOnService
  - Now outputs the correct verbose message when restarting the service.
- Changes to SqlServerMemory
  - Now outputs the correct verbose messages when calculating the dynamic
    memory, and when limiting maximum memory.
- Changes to SqlServerRole
  - Now outputs the correct verbose message when the members of a role is
    not in desired state.
- Changes to SqlAgentOperator
  - Fix minor issue that when unable to connect to an instance. Instead
    of showing a message saying that connect failed another unrelated
    error message could have been shown, because of an error in the code.
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Opt-in for 'Common Test - Validate Localization' johlju/SqlServerDsc
1 participant
@johlju