Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries for 8.1.0.0 ? #1578

Open
DarwinJS opened this issue Apr 1, 2020 · 14 comments
Open

Binaries for 8.1.0.0 ? #1578

DarwinJS opened this issue Apr 1, 2020 · 14 comments
Assignees

Comments

@DarwinJS
Copy link

DarwinJS commented Apr 1, 2020

The binaries for 8.1.0-Beta1 were packaged in chocolatey based on being made available here.

Now it seems 8.1.0.0 is released, but binaries are not built by openssh-portable. (https://github.com/PowerShell/Win32-OpenSSH/releases).

Is it possible to get the binaries for 8.1.0.0 here or are they available elsewhere?

@musm
Copy link

musm commented Apr 1, 2020

cc @manojampalam @bagajjal

@bagajjal
Copy link
Collaborator

bagajjal commented Apr 1, 2020

@DarwinJS - Are you referring to https://github.com/PowerShell/Win32-OpenSSH/releases/tag/v8.1.0.0p1-Beta.

If yes, why do you suspect these are not built by openssh-portable?

@DarwinJS
Copy link
Author

DarwinJS commented Apr 1, 2020

The confusion is with a prerelease being the latest available binaries here in this repo "v8.1.0.p1-beta" and a full release "v8.1.0.0" on openssh-portable for the source code.

@musm
Copy link

musm commented Apr 2, 2020

@DarwinJS aren't the binaries you want located here: https://github.com/PowerShell/Win32-OpenSSH/releases ?

@jborean93
Copy link

It sounds like this is just a mismatch on version info from the binaries here and the binaries on the Windows optional feature with the Windows optional feature just omitting the beta part. Are the hash's the same with the one located on GitHub?

@bagajjal
Copy link
Collaborator

bagajjal commented Apr 2, 2020

@DarwinJS - I just followed the previous convention.
openssh-portable has release name without "p1-beta" as opposed to win32-openssh but they meant same.

@jborean93 - The binaries shipped in windows are onecore binaries (work on all windows SKUs) where as github binaries are desktop binaries. The source code is same if the version is same.

We use the last part of version for windows releases when we deviate from github release.
For github releases the last part of version is always 0.

@jborean93
Copy link

@bagajjal why the divergance in releases, the code may be the same but why not just ship the onecore binaries for both and keep the version numbers the same, will remove the confusion. Is the onecore version not used in GitHub for backwards compatibility with older OS versions that Windows doesn't ship SSH as an optional feature to?

@bagajjal
Copy link
Collaborator

bagajjal commented Apr 2, 2020

version numbers will differ only when there is a code difference between windows and github versions. The divergence comes where there are security bugs (or) release timelines between windows & github doesn't align and we have to take some mandatory fixes into windows release.

@DarwinJS
Copy link
Author

DarwinJS commented Apr 3, 2020

@bagajjal - this seems very confusing.

Even if the versions needed to be different for some odd reason, it seems unusual to call it beta if it is really a production-grade release?

Wouldn't something like 8.1.0-desktop.0 be better?

@musm
Copy link

musm commented Apr 3, 2020

There's still an issue with the binaries uploaded to chocolatey they report an older version and in fact don't work with passphrase protected keys.

Reinstalling with the ones posted on github by microsoft fixed this issue (ssh -Version also reports the correct version 8.1)

@WSLUser
Copy link

WSLUser commented Apr 9, 2020

Even if the versions needed to be different for some odd reason, it seems unusual to call it beta if it is really a production-grade release?

I wouldn't consider it production ready until this PR is merged: PowerShell/openssh-portable#362 and #1322 is resolved.

@bagajjal
Copy link
Collaborator

Assigning to @maertendMSFT (OpenSSH PM) to finalize on the naming convention.

@DarwinJS
Copy link
Author

@bagajjal - If it not officially released yet - why is there a release with a non-prerelease sem version here: https://github.com/PowerShell/openssh-portable/releases/tag/v8.1.0.0

@bagajjal
Copy link
Collaborator

@DarwinJS - https://github.com/PowerShell/openssh-portable/releases is where we maintain our source code. As you pointed this repo doesn't use "P1-Beta" tag as it contains only the source code but no binaries. Going forward, I will maintain the same tag in both the repos (OpenSSH-Portable and Win32-OpenSSH).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants