Update build to clear node modules directory #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add removal of the node_modules directory on Clean task. Move condition for restore to the build prerequisite. This allows the restoring of node modules even if the folder exists.
This causes bad things to happen when you're editing in vscode (@types is locked until code exits) Next best thing might be to npm prune (or maybe npm install?)
|
While I was doing more work with this, I noticed that node_modules wasn't being deleted when I cleaned. It turns out that vscode was holding the @types directory locked and not allowing it to be removed. A side effect of this was that you also couldn't restore modules. A happy medium I think is to do an I've also included a slight change to |
rjmholt
approved these changes
Feb 8, 2019
TylerLeonhardt
pushed a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
Mar 18, 2019
* Update build to clear node modules Add removal of the node_modules directory on Clean task. Move condition for restore to the build prerequisite. This allows the restoring of node modules even if the folder exists. * Don't remove node_modules. This causes bad things to happen when you're editing in vscode (@types is locked until code exits) Next best thing might be to npm prune (or maybe npm install?) * npm install keeps putting these spaces in...
TylerLeonhardt
pushed a commit
that referenced
this pull request
Mar 20, 2019
* Update build to clear node modules Add removal of the node_modules directory on Clean task. Move condition for restore to the build prerequisite. This allows the restoring of node modules even if the folder exists. * Don't remove node_modules. This causes bad things to happen when you're editing in vscode (@types is locked until code exits) Next best thing might be to npm prune (or maybe npm install?) * npm install keeps putting these spaces in...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The main benefit of this is it keeps the build process in invoke-build when new node modules are added as they were recently.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.