Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify powerShellDefaultVersion desc to make clearer #1747

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

rkeithhill
Copy link
Collaborator

PR Summary

Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix #1734

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix #1734
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is much cleaner! Thanks @rkeithhill!

@TylerLeonhardt TylerLeonhardt merged commit 7610067 into master Feb 8, 2019
@TylerLeonhardt TylerLeonhardt deleted the rkeithhill/improve-defaultversion-desc branch February 8, 2019 23:02
TylerLeonhardt pushed a commit to TylerLeonhardt/vscode-powershell that referenced this pull request Mar 18, 2019
Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix PowerShell#1734
TylerLeonhardt pushed a commit that referenced this pull request Mar 20, 2019
Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix #1734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment for powershell.powerShellDefaultVersion should not complete full PowerShell Core Version
3 participants