Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Install-VSCode.ps1 script url with the one from master branch #1757

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

rafaltra
Copy link
Contributor

PR Summary

Install-VSCode.ps1 has been changed many times and default 'develop' branch has become stale. In README.md there is installation link which provides to Install-VSCode.ps1 from master branch. The text above recommends to check content of the script before launching, but redirects to old Install-VSCode.ps1 from develop branch. This small PR is changing this behaviour. Additionally setting language to command line.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

README.md Outdated Show resolved Hide resolved
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating that!

README.md Outdated Show resolved Hide resolved
Co-Authored-By: rafaltra <rafaltra@users.noreply.github.com>
@rjmholt rjmholt merged commit 34446b2 into PowerShell:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants