New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark ISE Theme #1051
Comments
dark theme that came in the spring? is that with the ISE preview thats in the gallery? |
@dotps1 This spring we added the PowerShell ISE Theme to the VSCode Extension. This theme mimics the color style of the ISE's defaults. The thought was that it would make transition to VSCode a bit more comfortable for those used to the ISE. It comes with the bright white editor and blue console that we all know and love. This was made possible with VSCode's 1.13 release which added the capability to color the terminal separately from the editor. I'd like to improve on that by adding another theme that keeps the integrated console's blue coloring, but with dark tones in the editor. |
A dark theme would be awesome! I'm OK with whatever direction you want to go with it, maybe start working on something that looks good to you and then post screenshots here for feedback from others? |
context: This should be just modifying https://github.com/PowerShell/vscode-powershell/blob/master/themes/theme-psise/theme.json as far as I know. |
Just a thought - if you change the user settings you can get the white on blue with any theme you like.
|
Oooo those look great! I think that's a great idea. Have these and the current ISE theme and I'd consider this issue resolved 😊 |
@tylerl0706 Thanks! I'll get this done soon - just want to add a little pizzazz to the terminal title bar in dark themes. What branch should I submit the PR to? |
Master is fine :) |
Did the Dark ISE Theme or Solarized Dark ISE ever get released int the wild to be easily installed within VSCode ? In my case I don't want to amend any of my currently installed themes just to have Dark ISE or Solarized Dark ISE when I toggle ISE Mode. |
@westerdaled nope Dark ISE mode is still up for grabs! |
I know it sounds dumb/ungrateful, but the lack of a dark theme is the one thing putting me off using the ISE mode (I'm a fan of the idea of the ISE mode, but the appearance of Powershell ISE was never its strong point, its main strengths were its simplicity and convenience). Is there a way to hack the colours used without having to create an extension (I don't mind if updates break these hacks)? I don't have the inclination to jump through the hoops of creating and maintaining an extension, I just want to be able to use the ISE mode without having to fry my eyesight with the current UI. |
You can use ISE Mode with a different theme. All you have to do is ctrl+shift+p to open the command pallet and set the color theme to whatever you'd like. One day, we may get an actual Dark ISE theme or a PowerShell blue console theme that you can apply on any theme... But we don't have it yet. When that comes, we can make ISE mode be configurable. |
@TylerLeonhardt , thank you for the advice. |
@Jess-S13 This GitHub repository is for the PowerShell extension for Microsoft Visual Studio Code. The ISE is pretty much dead; I'd highly recommend getting on board with VSCode. It's buggy, and far from perfect, but there are lots of benefits to learning about VSCode and altering your workflow somewhat. Believe me. 😁 |
@pcgeek86 They are asking about VSCode themes, not ISE. |
Hi @pcgeek86, Thank you for responding though! |
@Jess-S13 I totally missed what you meant, sorry about that! Can you just use a different dark theme, or are you specifically trying to replicate a very specific dark theme from the ISE? There are tons of theme packs that offer a variety of alternative themes. If I'm totally off-base, sorry again! 😆 |
I use the Extension URL: https://marketplace.visualstudio.com/items?itemName=samrapdev.outrun |
Hey @pcgeek86, |
I'll be totally honest. I'm not even sure what ISE Mode in Visual Studio Code is. 😆 To make sure I'm understanding the differences that you're seeing properly .... are you expecting tokens like You're right that the theme would control colorization of all of the PowerShell language tokens. I'd recommend playing around with a few different themes out on the VSCode Extensions Marketplace, and see how you like them. I don't think you'll ever get an exact one-to-one replication between the colors in ISE and VSCode, unless you invest a lot of engineering effort. Each of your team members would probably enjoy having the flexibility of swapping their theme on a daily, weekly, or monthly basis! It's much easier in VSCode than ISE. Personally, I think your [team's] time would be best spent accepting that there will be some minor colorization differences in VSCode, and focus on developing the best code possible. 🎉 There will be significant changes in how VSCode and ISE behave. The net benefit of using VSCode is 100% worth it though! Again, apologies if I'm misinterpreting something about your question! tl;dr Play around with a bunch of VSCode themes and see which ones each of you like the best. Embrace the thematic differences! Some are more contrasty, others less so. |
Hi @pcgeek86, |
For those who may stumble upon this after me. I followed this page -> https://www.alveeakand.com/how-to-modify-themes-in-vscode/ to edit the "ISE-Mode" theme to match the "Dark Editor"/"Dark Console" theme from the original ISE. You need the add in the following to your settings.json file and it will make it match. I had to add in a bunch of json lines at the bottom so the settings page was readable, but basically makes anything not powershell simply white on blue.. Hope it helps for anyone else:
|
So I'm thinking about adding a dark theme to go along with the ISE theme added this spring. My thoughts are that I'd like to keep the console colors as-is, but have dark theming in the editor. Also, I haven't decided whether the UI theming should be kept light like the current PowerShell ISE theme, or whether it should follow the editor theme.
Also, before I begin I'd like to get others thoughts on what they would like in a dark theme for the PowerShell extension. Some of the popular dark themes from other editors are Solarized, Monokai, Dracula,etc. Also, I just found a theme for VSCode from Cometeer called Spacemacs which is quite nice. If you're interested in a dark theme for PowerShell, please reply here with ideas for how you'd like it to look.
The text was updated successfully, but these errors were encountered: