Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark ISE Theme #1051

Open
mattmcnabb opened this issue Oct 11, 2017 · 26 comments
Open

Dark ISE Theme #1051

mattmcnabb opened this issue Oct 11, 2017 · 26 comments
Labels
Area-UI Hackathon Up for grabs, especially at Hackathons! Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@mattmcnabb
Copy link
Contributor

So I'm thinking about adding a dark theme to go along with the ISE theme added this spring. My thoughts are that I'd like to keep the console colors as-is, but have dark theming in the editor. Also, I haven't decided whether the UI theming should be kept light like the current PowerShell ISE theme, or whether it should follow the editor theme.

Also, before I begin I'd like to get others thoughts on what they would like in a dark theme for the PowerShell extension. Some of the popular dark themes from other editors are Solarized, Monokai, Dracula,etc. Also, I just found a theme for VSCode from Cometeer called Spacemacs which is quite nice. If you're interested in a dark theme for PowerShell, please reply here with ideas for how you'd like it to look.

@dotps1
Copy link

dotps1 commented Oct 11, 2017

dark theme that came in the spring? is that with the ISE preview thats in the gallery?

@mattmcnabb
Copy link
Contributor Author

@dotps1 This spring we added the PowerShell ISE Theme to the VSCode Extension. This theme mimics the color style of the ISE's defaults. The thought was that it would make transition to VSCode a bit more comfortable for those used to the ISE. It comes with the bright white editor and blue console that we all know and love. This was made possible with VSCode's 1.13 release which added the capability to color the terminal separately from the editor.

I'd like to improve on that by adding another theme that keeps the integrated console's blue coloring, but with dark tones in the editor.

@daviwil daviwil added Area-General Issue-Enhancement A feature request (enhancement). labels Oct 11, 2017
@daviwil
Copy link
Contributor

daviwil commented Oct 11, 2017

A dark theme would be awesome! I'm OK with whatever direction you want to go with it, maybe start working on something that looks good to you and then post screenshots here for feedback from others?

@pcgeek86
Copy link
Collaborator

Have you seen the Blackboard theme? I'm not really sure why, but it looks really pleasant and nice. I think it's the contrast that makes it easy to read, without being overly saturated color-wise.

image

@pcgeek86 pcgeek86 mentioned this issue Oct 16, 2017
@mattmcnabb
Copy link
Contributor Author

Working on a solarized one, but still have some UI elements to theme

image

Maybe we should have more than one?

@TylerLeonhardt TylerLeonhardt added the Hackathon Up for grabs, especially at Hackathons! label Feb 21, 2018
@TylerLeonhardt
Copy link
Member

context: This should be just modifying https://github.com/PowerShell/vscode-powershell/blob/master/themes/theme-psise/theme.json

as far as I know.

@TylerLeonhardt TylerLeonhardt added the Up for Grabs Will shepherd PRs. label Mar 20, 2018
@mbrinkho
Copy link

Just a thought - if you change the user settings you can get the white on blue with any theme you like.

    "workbench.colorCustomizations": {
        "terminal.background": "#012456",
        "terminal.foreground": "#F5F5F5"    }

@mattmcnabb
Copy link
Contributor Author

mattmcnabb commented Oct 23, 2018

I know it's been a while, but I just got around to looking at this again. Any objections if I start with recreating the default themes, but with the PowerShell console colors?

PowerShell Dark (Visual Studio)
powershell dark visual studio

PowerShell Dark+
powershell dark

PowerShell Light (Visual Studio)
powershell light visual studio

PowerShell Light+
powershell light

PowerShell Quiet Light
powershell quiet light

@TylerLeonhardt
Copy link
Member

Oooo those look great! I think that's a great idea. Have these and the current ISE theme and I'd consider this issue resolved 😊

@mattmcnabb
Copy link
Contributor Author

@tylerl0706 Thanks! I'll get this done soon - just want to add a little pizzazz to the terminal title bar in dark themes. What branch should I submit the PR to?

@TylerLeonhardt
Copy link
Member

Master is fine :)

@westerdaled
Copy link

Did the Dark ISE Theme or Solarized Dark ISE ever get released int the wild to be easily installed within VSCode ? In my case I don't want to amend any of my currently installed themes just to have Dark ISE or Solarized Dark ISE when I toggle ISE Mode.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Mar 28, 2020
@SydneyhSmith
Copy link
Collaborator

@westerdaled nope Dark ISE mode is still up for grabs!

@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label Mar 31, 2020
@ZenoArrow
Copy link

I know it sounds dumb/ungrateful, but the lack of a dark theme is the one thing putting me off using the ISE mode (I'm a fan of the idea of the ISE mode, but the appearance of Powershell ISE was never its strong point, its main strengths were its simplicity and convenience). Is there a way to hack the colours used without having to create an extension (I don't mind if updates break these hacks)? I don't have the inclination to jump through the hoops of creating and maintaining an extension, I just want to be able to use the ISE mode without having to fry my eyesight with the current UI.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label May 7, 2020
@TylerLeonhardt
Copy link
Member

You can use ISE Mode with a different theme.

All you have to do is ctrl+shift+p to open the command pallet and set the color theme to whatever you'd like.

One day, we may get an actual Dark ISE theme or a PowerShell blue console theme that you can apply on any theme... But we don't have it yet. When that comes, we can make ISE mode be configurable.

@ZenoArrow
Copy link

@TylerLeonhardt , thank you for the advice.

@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label May 12, 2020
@Jess-S13
Copy link

Forgive me if i'm asking this in the wrong forum, but is there a way in ISE-Mode to select the "Dark Editor"/"Dark Console" Theme that was used in PowerShell ISE? I tried just scrolling thru the massive number of themes in vscode and am having an issue finding this?
image

Thank you in advance,
Jess

@pcgeek86
Copy link
Collaborator

@Jess-S13 This GitHub repository is for the PowerShell extension for Microsoft Visual Studio Code. The ISE is pretty much dead; I'd highly recommend getting on board with VSCode. It's buggy, and far from perfect, but there are lots of benefits to learning about VSCode and altering your workflow somewhat. Believe me. 😁

@panekj
Copy link

panekj commented May 18, 2022

@pcgeek86 They are asking about VSCode themes, not ISE.

@Jess-S13
Copy link

@Jess-S13 This GitHub repository is for the PowerShell extension for Microsoft Visual Studio Code. The ISE is pretty much dead; I'd highly recommend getting on board with VSCode. It's buggy, and far from perfect, but there are lots of benefits to learning about VSCode and altering your workflow somewhat. Believe me. 😁

Hi @pcgeek86,
My apologies I was not clear. Im migrating from ISE to VSCode. Im trying to find out if the ISE-Mode in VSCode has the ISE Theme of "Dark Console"/"Dark Editor" which grabbed the screenshot of to show what I was referrring to. The ISE Mode light theme works fine but is very bright.

Thank you for responding though!

@pcgeek86
Copy link
Collaborator

@Jess-S13 I totally missed what you meant, sorry about that!

Can you just use a different dark theme, or are you specifically trying to replicate a very specific dark theme from the ISE? There are tons of theme packs that offer a variety of alternative themes.

If I'm totally off-base, sorry again! 😆

@pcgeek86
Copy link
Collaborator

pcgeek86 commented May 18, 2022

I use the Outrun Night theme for VSCode. Here's what my setup looks like:

Extension URL: https://marketplace.visualstudio.com/items?itemName=samrapdev.outrun

image

@Jess-S13
Copy link

Hey @pcgeek86,
No apology needed, im just thrilled someone is answering. Ive only ever worked in Powershell ISE as my team has only ever used 5x, but now were going to expand some use cases to 7x so im making the jump. The frustration I think is the best way of stating it, im experiencing is how the themes do not handle the different verbage in powershell the same way, an example being the amazing looking "Azure Contrast" here in this screenshot, colors strings & variables the same and variables and options the same, which is a large shift from ISE.
image
Actual PowerShell ISE:
image
ISE Mode in VSCode does this right (for the most part), so im thinking its a function of the theme, but as im just making the jump i was hoping it may be in the ISE mode itself as an option:
image

@pcgeek86
Copy link
Collaborator

@Jess-S13

I'll be totally honest. I'm not even sure what ISE Mode in Visual Studio Code is. 😆

To make sure I'm understanding the differences that you're seeing properly .... are you expecting tokens like MyFunction and Parameter and Get-ChildItem to all have different colors? And your team is concerned because they don't look quite as different in VSCode?

You're right that the theme would control colorization of all of the PowerShell language tokens. I'd recommend playing around with a few different themes out on the VSCode Extensions Marketplace, and see how you like them. I don't think you'll ever get an exact one-to-one replication between the colors in ISE and VSCode, unless you invest a lot of engineering effort.

Each of your team members would probably enjoy having the flexibility of swapping their theme on a daily, weekly, or monthly basis! It's much easier in VSCode than ISE.

Personally, I think your [team's] time would be best spent accepting that there will be some minor colorization differences in VSCode, and focus on developing the best code possible. 🎉 There will be significant changes in how VSCode and ISE behave. The net benefit of using VSCode is 100% worth it though!

Again, apologies if I'm misinterpreting something about your question!

tl;dr Play around with a bunch of VSCode themes and see which ones each of you like the best. Embrace the thematic differences! Some are more contrasty, others less so.

@Jess-S13
Copy link

Jess-S13 commented May 18, 2022

Hi @pcgeek86,
From what im gathering from https://docs.microsoft.com/en-us/powershell/scripting/dev-cross-plat/vscode/how-to-replicate-the-ise-experience-in-vscode?view=powershell-7.2 doc the ISE-Mode is part of the powershell extension which carries over alot of functionality from PowerShell ISE to VSCode to simplify the migration process for new users like myself. One of the parts of the ISE-Mode is the "ISE-Mode" theme which lines up really close to the PowerShell ISE Dark Console/Light Editor theme from Powershell-ISE. As Ive always used the Dark/Dark theme and I saw this thread I figured it was worth asking if this already exists and I just missed it before I try to COOK (not look) up my own as the existing dark themes handle some parts a little weird.

@Jess-S13
Copy link

For those who may stumble upon this after me. I followed this page -> https://www.alveeakand.com/how-to-modify-themes-in-vscode/ to edit the "ISE-Mode" theme to match the "Dark Editor"/"Dark Console" theme from the original ISE. You need the add in the following to your settings.json file and it will make it match. I had to add in a bunch of json lines at the bottom so the settings page was readable, but basically makes anything not powershell simply white on blue.. Hope it helps for anyone else:

Here is how it looks:
image

"workbench.activityBar.visible": false, "debug.openDebug": "neverOpen", "workbench.startupEditor": "none", "workbench.colorCustomizations": { "[PowerShell ISE]": { "terminal.foreground" : "#EDEEF0", "terminal.background" : "#012456", "editor.background": "#012456", "editorCursor.foreground": "#f5f5f5", "editor.lineHighlightBackground": "#012456", } }, "editor.tokenColorCustomizations": { "[PowerShell ISE]": { "textMateRules": [ { "scope": [ "comment.line.powershell", ], "settings": { "foreground": "#98fb98" } }, { "scope": [ "support.function.attribute.powershell", ], "settings": { "foreground": "#b0c4de" } }, { "scope": [ "support.function.powershell", "meta.function.powershell", "meta.scriptblock.powershell", "keyword.control.powershell", ], "settings": { "foreground": "#e0ffff" } }, { "scope": [ "entity.name.function.powershell", "source.powershell", ], "settings": { "foreground": "#ee82ee" } }, { "scope": [ "punctuation.section.group.end.powershell", "punctuation.section.group.begin.powershell", "keyword.operator.other.powershell", "variable.parameter.attribute.powershell", "punctuation.terminator.statement.powershell", "punctuation.section.braces.begin.powershell", "punctuation.section.braces.end.powershell", "meta.group.simple.subexpression.powershell", "variable.other.member.powershell", "support.type.property-name.json", "string.json", "punctuation.definition.dictionary.end.json", "punctuation.definition.dictionary.begin.json", "punctuation.separator.dictionary.pair.json", "punctuation.separator.array.json", "punctuation.definition.array.begin.json", "punctuation.definition.array.end.json", "punctuation.separator.dictionary.key-value.json", "support.type.property-name.json", "punctuation.support.type.property-name.begin.json", "punctuation.support.type.property-name.end.json", "string.quoted.double.json", "punctuation.definition.string.begin.json", "punctuation.definition.string.end.json", ], "settings": { "foreground": "#f5f5f5" } }, { "scope": [ "constant.numeric.integer.powershell", ], "settings": { "foreground": "#ffe4c4" } }, { "scope": [ "punctuation.section.bracket.begin.powershell", "punctuation.section.bracket.end.powershell", ], "settings": { "foreground": "#d3d3d3" } }, { "scope": [ "string.quoted.single.powershell", "string.quoted.double.powershell", "punctuation.definition.string.begin.powershell", "punctuation.definition.string.end.powershell", ], "settings": { "foreground": "#db7094" } }, { "scope": [ "variable.other.readwrite.powershell", "constant.language.powershell", ], "settings": { "foreground": "#ff4400" } }, { "scope": [ "storage.type.powershell", ], "settings": { "foreground": "#e0ffff" } }, ], } }, "editor.tabCompletion": "on", "editor.autoClosingBrackets": "never", "editor.autoClosingQuotes": "never", "editor.defaultFormatter": "ms-vscode.powershell", "powershell.integratedConsole.focusConsoleOnExecute": false, "editor.wordSeparators": "~!@#%^&*()-=+[{]}\|;:'",.<>/?",
"powershell.buttons.showPanelMovementButtons": true,
"workbench.colorTheme": "PowerShell ISE",
"editor.bracketPairColorization.enabled": false`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Hackathon Up for grabs, especially at Hackathons! Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests