Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new breakpoint column support in VSCode #2237

Open
Glober777 opened this issue Oct 10, 2019 · 2 comments
Open

Add support for new breakpoint column support in VSCode #2237

Glober777 opened this issue Oct 10, 2019 · 2 comments
Labels
Area-Debugging Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@Glober777
Copy link

Summary of the new feature

VSCode in version 1.39 has got a new feature called Improved UI for column breakpoints:
https://code.visualstudio.com/updates/v1_39#_improved-ui-for-column-breakpoints

According to the release notes, the capability needs to be supported by the underlying runtime/debugger. It would be really handy to be able to set breakpoints in a middle of a one-liner (or for a sub-expression) when working with PowerShell.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Oct 10, 2019
@rjmholt rjmholt added Area-Debugging Issue-Enhancement A feature request (enhancement). labels Oct 10, 2019
@SydneyhSmith SydneyhSmith removed the Needs: Triage Maintainer attention needed! label Oct 10, 2019
@SydneyhSmith
Copy link
Collaborator

@globber777 thanks for opening this issue and providing the link to the documentation! I agree that this would be an awesome feature to have but will add the "Up For Grabs" tag since we currently do not have committed time to implement this.

@SydneyhSmith SydneyhSmith added the Up for Grabs Will shepherd PRs. label Oct 10, 2019
@TylerLeonhardt
Copy link
Member

Just to throw down some context...

this is done using the breakpoint locations message in the debug adapter protocol.

In order to support this:

  1. Find a way to get PowerShell to return the possible breakpoint locations (preferably via the PowerShell API and not by running a command)
  2. Add support for the breakpoint locations message to csharp-language-server-protocol
  3. Add a new Handler in PowerShell Editor Services in this directory with the code you discovered in number 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Debugging Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

4 participants