Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping a script while being prompted for mandatory parameter input crashes integrated shell #617

Closed
dotps1 opened this issue Mar 24, 2017 · 2 comments
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@dotps1
Copy link

dotps1 commented Mar 24, 2017

System Details

  • Operating system name and version: 10.0.14393
  • VS Code version: 1.10.2
  • PowerShell extension version: 0.11.0
  • Output from $PSVersionTable:
Name                           Value
----                           -----
PSVersion                      5.1.14393.953
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.953
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

create a basic script with this param block:

param (
    [Parameter(
        Mandatory = $true
    )
    [String[]]
    $MandatoryParameter
)

execute the script with F5, then hit the Stop to stop debugging, the integrated shell is still looking for input. hit enter, and the shell crashes, and cannot get reopend with out starting a new instance of code.

hitting F5 again causes this to pop up:
image

Attached Logs

let me know if you cannot recreate and ill get some logs.

@daviwil daviwil modified the milestone: 0.11.1 Mar 24, 2017
@daviwil
Copy link
Contributor

daviwil commented Mar 24, 2017

Thanks! I'll take a look for next week's patch update.

@daviwil daviwil added the Issue-Bug A bug to squash. label Mar 24, 2017
@daviwil daviwil modified the milestones: Next Patch Update, Next Feature Update Apr 6, 2017
@daviwil daviwil modified the milestones: April 2017, May 2017, 1.0.0-beta1 May 8, 2017
@daviwil
Copy link
Contributor

daviwil commented May 9, 2017

This should be fixed now with the fix to PowerShell/PowerShellEditorServices#428, update coming soon!

@daviwil daviwil closed this as completed May 9, 2017
@daviwil daviwil modified the milestones: 1.0.0-beta1, 1.0.0 May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants