Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xActiveDirectory: Migrate Pester test syntax from v3 -> v4 #322

Closed
johlju opened this issue Jun 5, 2019 · 2 comments
Closed

xActiveDirectory: Migrate Pester test syntax from v3 -> v4 #322

johlju opened this issue Jun 5, 2019 · 2 comments
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jun 5, 2019

As of Pester v4 the syntax of the Should cmdlet has changed from for example Should Be to Should -Be.

There is a helpful script that can be used to easily perform the conversion:
https://gist.github.com/indented-automation/aeb14825e39dd8849beee44f681fbab3

This script should be used to correct the Pester syntax in all unit tests.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jun 5, 2019
@johlju johlju added this to To do in All issues and PR's Jun 5, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jun 7, 2019
@johlju
Copy link
Member Author

johlju commented Jun 7, 2019

I'm working on this one

johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jun 7, 2019
@johlju
Migrate tests to Pester syntax v4.x (issue dsccommunity#322)
b410d42
@johlju johlju mentioned this issue Jun 7, 2019
Merged
9 tasks
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jun 8, 2019
@johlju
Migrate tests to Pester syntax v4.x (issue dsccommunity#322)
80a5e19
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jun 13, 2019
@johlju
Migrate tests to Pester syntax v4.x (issue dsccommunity#322)
b487368
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jun 15, 2019
@johlju
Migrate tests to Pester syntax v4.x (issue dsccommunity#322)
b44554b
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jun 15, 2019
@johlju
Migrate tests to Pester syntax v4.x (issue dsccommunity#322)
f8abf91
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jun 15, 2019
@johlju
Migrate tests to Pester syntax v4.x (issue dsccommunity#322)
8aff5a7
johlju added a commit that referenced this issue Jun 16, 2019
@johlju
xActiveDirectory: Cleanup code (#326)
82d6076 
- Changes to xActiveDirectory
  - Cleanup of code
    - Removed semicolon throughout where it is not needed.
    - Migrate tests to Pester syntax v4.x (issue #322).
    - Removed `-MockWith {}` in unit tests.
- Changes to xADRecycleBin
  - Code cleanup.
  - It now set back the `$ErrorActionPreference` that was set prior to
    setting it to `'Stop'`.
- Changes to xADDomainDefaultPasswordPolicy
  - Code cleanup.
- Changes to xADDomainTrust
  - Code cleanup.
- Changes to xADForestProperties
  - Minor style cleanup.
- Changes to xADOrganizationalUnit
  - Code cleanup.
- Changes to xADReplicationSiteLink
  - Code cleanup.
- Changes to xADReplicationSubnet
  - Code cleanup.
- Changes to xADKDSKey
  - Code cleanup.
- Changes to xADManagedServiceAccount
  - Code cleanup.
- Changes to xADServicePrincipalName
  - Code cleanup.
- Changes to xWaitForADDomain
  - Code cleanup.
- Changes to xADDomainController
  - Code cleanup.
- Changes to xADObjectPermissionEntry
  - Code cleanup.
- Changes to xADGroup
  - Code cleanup.
- Changes to xADUser
  - Code cleanup.
- Changes to xADDomain
  - Code cleanup.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 16, 2019
@johlju
Copy link
Member Author

johlju commented Jun 16, 2019

This was merged in PR #326

@johlju johlju closed this as completed Jun 16, 2019
All issues and PR's automation moved this from To do to Done Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju