Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xADUser: Replace Write-Error with the correct helper function #331

Closed
johlju opened this issue Jun 7, 2019 · 0 comments · Fixed by #392
Closed

xADUser: Replace Write-Error with the correct helper function #331

johlju opened this issue Jun 7, 2019 · 0 comments · Fixed by #392
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
All issues and PR's Remove 'x' from module name

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

This resource is wrongly using Write-Error and then after that throw. It should instead use the helper functions here to throw errors https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#helper-functions-for-localization

The unit tests should be updated accordingly, making sure it throws the correct error message (not just any error message).
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jun 7, 2019
@johlju johlju added this to To do in All issues and PR's Jun 12, 2019
@X-Guardian X-Guardian mentioned this issue Jun 24, 2019
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 25, 2019
@johlju johlju moved this from To do to In progress in Remove 'x' from module name Jun 25, 2019
All issues and PR's automation moved this from To do to Done Jun 25, 2019
Remove 'x' from module name automation moved this from In progress to Done Jun 25, 2019
johlju pushed a commit that referenced this issue Jun 25, 2019
@X-Guardian @johlju
xADUser: Replace Write-Error with the correct helper function (#392)
0f7c18c 
- Changes to xADUser
  - Replace Write-Error with the correct helper function (issue #331).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
All issues and PR's
  
Done
Remove 'x' from module name
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xADUser: Replace Write-Error with the correct helper function
1 participant
@johlju