Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xActiveDirectory: Use fully qualified type names for parameters and variables #374

Closed
johlju opened this issue Jun 15, 2019 · 0 comments · Fixed by #385
Closed

xActiveDirectory: Use fully qualified type names for parameters and variables #374

johlju opened this issue Jun 15, 2019 · 0 comments · Fixed by #385
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jun 15, 2019 •
edited
Loading

We should change the type names to be fully qualified. For example

[String] to [System.String]
[Boolean] to [System.Boolean]
PSCredential to [System.Management.Automation.PSCredential]
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 15, 2019
@johlju johlju added this to To do in All issues and PR's via automation Jun 15, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 19, 2019
@johlju johlju mentioned this issue Jun 19, 2019
Merged
9 tasks
All issues and PR's automation moved this from To do to Done Jun 21, 2019
johlju added a commit that referenced this issue Jun 21, 2019
@johlju
xActiveDirectory: Use fully qualified type names (#385)
727474a 
- Changes to xActiveDirectory
  - Cleanup of code
    - Use fully qualified type names for parameters and variables
      (issue #374).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xActiveDirectory: Use fully qualified type names johlju/ActiveDirectoryDsc
1 participant
@johlju