Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xFailOverCluster: Add CodeCov and make sure this module opt-in for the common tests that could be used #41

Closed
johlju opened this issue Jun 13, 2017 · 0 comments · Fixed by #65
Closed

xFailOverCluster: Add CodeCov and make sure this module opt-in for the common tests that could be used #41

johlju opened this issue Jun 13, 2017 · 0 comments · Fixed by #65
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 13, 2017

Suggest we add CodeCov to this module, and make sure this module opt-in for the common tests that could be used.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 13, 2017
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jun 17, 2017
@johlju
Changes to xFailOverCluster
d250d02 
- Added CodeCov and opt-in for all common tests (issue dsccommunity#41).
- Fixed typo in README.md.
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jun 17, 2017
@johlju
Changes to xFailOverCluster
bb2e9df 
- Added CodeCov and opt-in for all common tests (issue dsccommunity#41).
- Fixed typo in README.md.
@johlju johlju mentioned this issue Jun 17, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Jun 19, 2017
@johlju
Merge pull request #65 from johlju/add-codecov
343441c 
xFailOverCluster: Added CodeCov plus Opt-in for common tests

- Changes to xFailOverCluster
  - Added CodeCov and opt-in for all common tests (issue #41).
  - Added CodeCov badge to README.md
  - Fixed lint rule MD013 in CHANGELOG.md.
  - Fixed lint rule MD013 in README.md.
  - Fixed lint rule MD024 in README.md.
  - Fixed lint rule MD032 in README.md.
  - Removed example from README.md (issue #42).
  - Fixed typo in filename for ISSUE\_TEMPLATE. Was 'ISSUE\_TEMPLATE', now it is
    correctly 'ISSUE\_TEMPLATE.md'.
  - Changed appveyor.yml to use the new default test framework in the AppVeyor
    module in DscResource.Tests (AppVeyor.psm1).
- Changes to xCluster
  - Added examples
    - 1-CreateFirstNodeOfAFailoverCluster.ps1
    - 2-JoinAdditionalNodeToFailoverCluster.ps1
    - 3-CreateFailoverClusterWithTwoNodes.ps1 (this is the example from README.md)
  - Fixed typo in xCluster parameter description.
  - Added links to examples from README.md
- Changes to xWaitForCluster
  - Added example
    - 1-WaitForFailoverClusterToBePresent.ps1
  - Added link to example from README.md
@joeyaiello joeyaiello removed the help wanted The issue is up for grabs for anyone in the community. label Jun 19, 2017
@johlju johlju removed their assignment Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xFailOverCluster: Added CodeCov plus Opt-in for common tests johlju/FailoverClusterDsc
2 participants
@joeyaiello @johlju