Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xClusterPreferredOwner: Script Analyzer warnings that need to be fixed #50

Closed
johlju opened this issue Jun 13, 2017 · 1 comment
Closed

xClusterPreferredOwner: Script Analyzer warnings that need to be fixed #50

johlju opened this issue Jun 13, 2017 · 1 comment

Comments

@johlju
Copy link
Member

johlju commented Jun 13, 2017

MSFT_xClusterPreferredOwner.psm1 (Line 8): The 'Key' parameter 'ClusterName' is not present in 'Get-TargetResource' DSC resource function(s).
MSFT_xClusterPreferredOwner.psm1 (Line 65): The 'Key' parameter 'ClusterName' is not present in 'Set-TargetResource' DSC resource function(s).
MSFT_xClusterPreferredOwner.psm1 (Line 153): The 'Key' parameter 'ClusterName' is not present in 'Test-TargetResource' DSC resource function(s).
@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Jun 13, 2017
@johlju
Copy link
Member Author

johlju commented Jun 13, 2017

This is failing tests, so this need to be resolved.

https://ci.appveyor.com/project/johlju/xfailovercluster/build/1.6.1.0#L170

johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jun 14, 2017
@johlju
Changes to xClusterPreferredOwner
8ba5807 
- Script Analyzer warnings have been fixed (issue dsccommunity#50). This also failed the tests for the resource.
@johlju johlju mentioned this issue Jun 14, 2017
Merged
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 14, 2017
@johlju johlju self-assigned this Jun 14, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 14, 2017
@bgelens bgelens removed the bug The issue is a bug. label Jun 14, 2017
@johlju johlju removed their assignment Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johlju @bgelens