Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xNetBIOS: InterfaceAlias not working properly #315

Closed
aalmeida89 opened this issue Mar 5, 2018 · 6 comments · Fixed by #316 or #336
Closed

xNetBIOS: InterfaceAlias not working properly #315

aalmeida89 opened this issue Mar 5, 2018 · 6 comments · Fixed by #316 or #336
Assignees
Labels
bug The issue is a bug.

Comments

@aalmeida89
Copy link

I'm having a problem enabling netBIOS. My file is like it:
xNetBIOS EnableNetBIOS
{
InterfaceAlias = 'ethernet0'
Setting = 'Enable'
}
When I use InterfaceAlias as "Ethernet0" it returns the error: System.InvalidOperationException: Interface 'ethernet0' was not found.
To find InterfaceAlias, I am doing the PS query:
Get-NetIPAddress | where IPAddress -eq "..." | fl interfaceAlias
and it returns:
interfaceAlias : Ethernet0
I am using the correct name.
When I query "Get-NetAdapter | fl Name,InterfaceDescription" it returns:
Name : Ethernet0
InterfaceDescription : Intel(R) 82574L Gigabit Network Connection

Then Im trying
xNetBIOS EnableNetBIOS
{
InterfaceAlias = 'Intel(R) 82574L Gigabit Network Connection'
Setting = 'Enable'
}
and it changes well. I think InterfaceAlias is not suppose to be it. Going further in my investigation I opened the file "MSFT_xNetBIOS.psm1" and go to "function Test-TargetResource" (line 190) to find what it is doing. At line 208 have it:
$netAdapter = Get-CimInstance -ClassName Win32_NetworkAdapter
-Filter ('Name="{0}"' -f $InterfaceAlias)
then I query "Get-CimInstance -ClassName Win32_NetworkAdapter | select name" and none of them is "Ethernet0", so looking for "ethernet0" I found it at NetConnectionID:
NetConnectionID : Ethernet0
query: Get-CimInstance -ClassName Win32_NetworkAdapter | select NetConnectionID

All my nodes are running Powershell 5.1 and i'm using xNetworking 5.5.0 (master branch I guess)
PS
Major Minor Build Revision


5 1 14393 693
xNetworking
Version Name


5.5.0.0 xNetworking

@PlagueHO PlagueHO added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Mar 5, 2018
@PlagueHO
Copy link
Member

PlagueHO commented Mar 5, 2018

Hi @aalmeida89 - it looks like a change was made in the last release that broke this. I'll get this fixed ASAP. It should still work fine in 5.4.0.0. Thanks for raising this.

@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 5, 2018
@aalmeida89
Copy link
Author

Thanks a lot =).

PlagueHO added a commit that referenced this issue Apr 3, 2018
xNetBios: Fix issue with InterfaceAlias matching on Adapter description - Fixes #315
@matt6697
Copy link

matt6697 commented Jun 1, 2018

Fix available in 5.7.0.0 (not 5.6.0.0 as stated in the changelog !)

@PlagueHO
Copy link
Member

PlagueHO commented Jun 1, 2018

@johlju - any thoughts on what we should do here? Fix the changelog?

@johlju
Copy link
Member

johlju commented Jun 1, 2018

You could fix the change log in this repo, but don't think we can (read have time) to resolve the release notes in PowerShell Gallery. I have no permission there.
You could add a note in next release's change log (under the Unreleased section) mentioning the mistake too?

@PlagueHO
Copy link
Member

PlagueHO commented Jun 3, 2018

Thanks @johlju - I think you're right and going back and changing past packages is a no-no in general. So I'll just submit a PR to correct the CHANGELOG.MD.

@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 4, 2018
PlagueHO added a commit that referenced this issue Jun 4, 2018
Correction to CHANGELOG.MD - Fixes #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
4 participants