New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests not running because of naming convention. #16
Conversation
@TraGicCode thanks for fixing the tests! 😄 Just a few review comments. Reviewed 4 of 5 files at r1. README.md, line 13 at r1 (raw file):
To get badges working for codecov there is a bit more that is needed (updated appveyor.yml). I suggest Codecov support is added in a separate PR, and that we remove this row from this PR. README.md, line 21 at r1 (raw file):
Please see previous comment. README.md, line 43 at r1 (raw file):
We got the wrong issue number here. Tests/Unit/MSFT_xPowerShellExecutionpolicy.test.ps1, line 118 at r1 (raw file):
Was test remove for a specific reason? It seemed to test the Comments from Reviewable |
Review status: all files reviewed at latest revision, 4 unresolved discussions. README.md, line 13 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. README.md, line 21 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Review status: 2 of 3 files reviewed at latest revision, 4 unresolved discussions. README.md, line 43 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions. Tests/Unit/MSFT_xPowerShellExecutionpolicy.test.ps1, line 118 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
I actually got confused with the name. I thought it was a duplicate test. I added the test back and fixed the test name to make it correct. Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions. Tests/Unit/MSFT_xPowerShellExecutionpolicy.test.ps1, line 118 at r1 (raw file): Previously, TraGicCode (Michael Fyffe) wrote…
Done. Comments from Reviewable |
@kwirkykat @mbreakey3 could you look at this and merge whenever you can? This makes the tests run correctly in AppVeyor. Reviewed 2 of 3 files at r2. Comments from Reviewable |
This renames the tests file so that unit tests actually run in appveyor and when you run Invoke-Pester locally without explicitly passing the name of the file.
I Also went ahead and fixed the PSSA rules and markdown linting issues.
Fixes #17
This change is