Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests not running because of naming convention. #16

Merged
merged 9 commits into from Apr 20, 2018
Merged

Unit Tests not running because of naming convention. #16

merged 9 commits into from Apr 20, 2018

Conversation

TraGicCode
Copy link
Contributor

@TraGicCode TraGicCode commented Apr 13, 2018

This renames the tests file so that unit tests actually run in appveyor and when you run Invoke-Pester locally without explicitly passing the name of the file.

I Also went ahead and fixed the PSSA rules and markdown linting issues.

Fixes #17


This change is Reviewable

@johlju
Copy link
Member

johlju commented Apr 13, 2018

@TraGicCode thanks for fixing the tests! 😄 Just a few review comments.


Reviewed 4 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


README.md, line 13 at r1 (raw file):

[![Build status](https://ci.appveyor.com/api/projects/status/y2ohjd5q86oagghu/branch/master?svg=true)](https://ci.appveyor.com/project/PowerShell/xPowerShellExecutionPolicy/branch/master)
[![codecov](https://codecov.io/gh/PowerShell/xPowerShellExecutionPolicy/branch/master/graph/badge.svg)](https://codecov.io/gh/PowerShell/xPowerShellExecutionPolicy/branch/master)

To get badges working for codecov there is a bit more that is needed (updated appveyor.yml). I suggest Codecov support is added in a separate PR, and that we remove this row from this PR.


README.md, line 21 at r1 (raw file):

[![Build status](https://ci.appveyor.com/api/projects/status/y2ohjd5q86oagghu/branch/dev?svg=true)](https://ci.appveyor.com/project/PowerShell/xPowerShellExecutionPolicy/branch/dev)
[![codecov](https://codecov.io/gh/PowerShell/xPowerShellExecutionPolicy/branch/dev/graph/badge.svg)](https://codecov.io/gh/PowerShell/xPowerShellExecutionPolicy/branch/dev)

Please see previous comment.


README.md, line 43 at r1 (raw file):

[issue #1088]

We got the wrong issue number here.


Tests/Unit/MSFT_xPowerShellExecutionpolicy.test.ps1, line 118 at r1 (raw file):

            }

            It 'Throws when passed an invalid execution policy' {

Was test remove for a specific reason? It seemed to test the Scope parameter. Maybe the It-block description should have been updated.


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 4 unresolved discussions.


README.md, line 13 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

To get badges working for codecov there is a bit more that is needed (updated appveyor.yml). I suggest Codecov support is added in a separate PR, and that we remove this row from this PR.

Done.


README.md, line 21 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Please see previous comment.

Done.


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

Review status: 2 of 3 files reviewed at latest revision, 4 unresolved discussions.


README.md, line 43 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
[issue #1088]

We got the wrong issue number here.

Done.


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions.


Tests/Unit/MSFT_xPowerShellExecutionpolicy.test.ps1, line 118 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Was test remove for a specific reason? It seemed to test the Scope parameter. Maybe the It-block description should have been updated.

I actually got confused with the name. I thought it was a duplicate test. I added the test back and fixed the test name to make it correct.


Comments from Reviewable

@TraGicCode
Copy link
Contributor Author

Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions.


Tests/Unit/MSFT_xPowerShellExecutionpolicy.test.ps1, line 118 at r1 (raw file):

Previously, TraGicCode (Michael Fyffe) wrote…

I actually got confused with the name. I thought it was a duplicate test. I added the test back and fixed the test name to make it correct.

Done.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Apr 14, 2018

:lgtm:

@kwirkykat @mbreakey3 could you look at this and merge whenever you can? This makes the tests run correctly in AppVeyor.


Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju mentioned this pull request Apr 14, 2018
@johlju johlju merged commit 8be95b9 into dsccommunity:dev Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests don't run locally or in CI
2 participants