Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update json file if already exist and add comments #7

Closed
wants to merge 2 commits into from

Conversation

ngdream
Copy link

@ngdream ngdream commented Sep 4, 2022

πŸ› οΈ Fixes Issue

πŸ‘¨β€πŸ’» Changes proposed

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request πŸŽ‰.

Soon one of our maintainers will review it and provide you with feedback/suggestions. If you think it's something urgent, feel free to reach out Pradumna Saraf on Twitter. Star ⭐ this repo to show us support.

Happy, Open Source!

src/index.js Outdated Show resolved Hide resolved
Co-authored-by: Tom Schmelzer <30869493+schmelto@users.noreply.github.com>
@Pradumnasaraf
Copy link
Owner

Pradumnasaraf commented Sep 20, 2022

Sorry, I missed this PR. I will test and check this weekend. Thank you!

Copy link
Owner

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I just tested it out and found a catch, that it's prompting creating.... even if the user with that user is not found on GitHub.

Screenshot from 2022-09-25 19-23-22

@Pradumnasaraf
Copy link
Owner

Pradumnasaraf commented Oct 19, 2022

No activity, closing this PR. Thank you, for your effort and time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants