Skip to content

Commit

Permalink
Deprecate elixir 1.3 so we can use split_with and no warnings on 1.6
Browse files Browse the repository at this point in the history
  • Loading branch information
PragTob committed Jan 3, 2018
1 parent d22f98e commit e793297
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
elixir 1.5.2
elixir 1.6.0-rc.0
erlang 20.0
9 changes: 4 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
language: elixir
elixir:
- 1.3.4
- 1.4.5
- 1.5.2
- 1.5.3
- 1.6.0-rc.0
otp_release:
- 18.3
- 19.3
- 20.0
- 20.2
matrix:
exclude:
- elixir: 1.3.4
otp_release: 20.0
- elixir: 1.6.0-rc.0
otp_release: 18.3

before_script:
- MIX_ENV=test mix compile --warnings-as-errors
Expand Down
2 changes: 1 addition & 1 deletion lib/benchee.ex
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ for {module, moduledoc} <- [{Benchee, elixir_doc}, {:benchee, erlang_doc}] do
defp output_results(suite = %{configuration: %{formatters: formatters}}) do
# Can be replaced with `split_with` once we deprecate elixir 1.3
{parallelizable, serial} =
Enum.partition(formatters, &is_formatter_module?/1)
Enum.split_with(formatters, &is_formatter_module?/1)

# why do we ignore this suite? It shouldn't be changed anyway.
_suite = Formatter.parallel_output(suite, parallelizable)
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ defmodule Benchee.Mixfile do
[
app: :benchee,
version: @version,
elixir: "~> 1.3",
elixir: "~> 1.4",
elixirc_paths: elixirc_paths(Mix.env),
consolidate_protocols: true,
build_embedded: Mix.env == :prod,
Expand Down

0 comments on commit e793297

Please sign in to comment.