Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally show additional statistics in console output #50

Closed
PragTob opened this issue Nov 25, 2016 · 4 comments
Closed

Optionally show additional statistics in console output #50

PragTob opened this issue Nov 25, 2016 · 4 comments

Comments

@PragTob
Copy link
Member

PragTob commented Nov 25, 2016

an option for the console formatter like extended_statistics or something would be nice to show statistics that we already collect but don't print yet. As of now this would be:

  • minimum
  • maximum
  • sample size

These values can be interesting for different reasons, e.g. what is the worst case performance here or on how many results is this based. I don't really want to add them to the standard console formatter as the output would probably get too wide.

The new/extra statistics should probably be displayed underneath the normal statistics in a smiliar fashion as the normal statistics, meaning in the same order and in a table like format that goes:

name - minimum - maximum - sample size

@h4cc
Copy link

h4cc commented Feb 26, 2017

A starting point for this would be here: https://github.com/PragTob/benchee/blob/master/lib/benchee/formatters/console.ex#L76

@narrowtux
Copy link

.

@lwalter
Copy link
Contributor

lwalter commented Oct 16, 2017

@PragTob Mind if I pick this one up?

@PragTob
Copy link
Member Author

PragTob commented Oct 16, 2017

@lwalter nah not at all :) I'd be happy about it 🎉 , feels bad that we calculate all those values but rarely show them!

There is also a new value that might fit into there quite well that we have now, which is the mode! Not sure yet if I want to turn them on or off by default, but that's just one line to change in Configuration so it'd be cool.

I aim to cut a release relatively soon, so depending on what happens it might have to wait out that release but should ship soon after or maybe it'll even make the release :)

As always, feel free to start with an early PR with questions and direction if you feel like it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants