Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to updated Elixir and Erlang versions #228

Merged
merged 4 commits into from
Jul 26, 2018
Merged

Move to updated Elixir and Erlang versions #228

merged 4 commits into from
Jul 26, 2018

Conversation

devonestes
Copy link
Collaborator

No description provided.

@PragTob
Copy link
Member

PragTob commented Jun 21, 2018

Thanks!

Seems like we have some legit memory failures and I think we might need to exclude 1.4/1.5 for OTP 21.

@PragTob
Copy link
Member

PragTob commented Jun 23, 2018

Yeah memory measurements somehow break... the old scenario from @michalmuskala (that we gladly tested) breaks and so does some simple stuff like: fn -> Enum.map([1, 2, 3], fn i -> i + 1 end) end

It gets exactly the same heap information before/after... which makes no sense unless this scenario is now optimized/inlined as well:

[
  old_heap_block_size: 0,
  heap_block_size: 233,
  mbuf_size: 0,
  recent_size: 0,
  stack_size: 13,
  old_heap_size: 0,
  heap_size: 220,
  bin_vheap_size: 0,
  bin_vheap_block_size: 46422,
  bin_old_vheap_size: 0,
  bin_old_vheap_block_size: 46422
]
[
  old_heap_block_size: 0,
  heap_block_size: 233,
  mbuf_size: 0,
  recent_size: 0,
  stack_size: 13,
  old_heap_size: 0,
  heap_size: 220,
  bin_vheap_size: 0,
  bin_vheap_block_size: 46422,
  bin_old_vheap_size: 0,
  bin_old_vheap_block_size: 46422
]

(also no memory collected)

@PragTob
Copy link
Member

PragTob commented Jun 23, 2018

Still pushed my upgrade to remove the unfitting builds from the built matrix... leaving this alone again now because the 3 failures seem hard to figure out :(

@PragTob
Copy link
Member

PragTob commented Jul 15, 2018

In case anyone sees this and thinks wtf they aren't working on this... we are but it's hard and we're scratching all our heads.

@PragTob
Copy link
Member

PragTob commented Jul 24, 2018

Ok the memory measurement problems exist whether we merge this or not... I think we'll skip the problematic tests on OTP 21 until we merge them :)

@PragTob PragTob merged commit a072fba into master Jul 26, 2018
@PragTob PragTob deleted the update-versions branch July 26, 2018 17:15
PragTob pushed a commit that referenced this pull request Aug 2, 2018
* Move to updated Elixir and Erlang versions

* Exclude unsupported elixir<->otp configurations

* exclude problematic tests for now, filed #234 to follow up

* Old OTP or elixir versions are not yet ready for the mighty ł
PragTob pushed a commit that referenced this pull request Aug 2, 2018
* Move to updated Elixir and Erlang versions

* Exclude unsupported elixir<->otp configurations

* exclude problematic tests for now, filed #234 to follow up

* Old OTP or elixir versions are not yet ready for the mighty ł
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants