-
Notifications
You must be signed in to change notification settings - Fork 315
/
question.js
2085 lines (1996 loc) · 73.2 KB
/
question.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
const ERR = require('async-stacktrace');
const _ = require('lodash');
const async = require('async');
const path = require('path');
const jsonStringifySafe = require('json-stringify-safe');
const debug = require('debug')('prairielearn:' + path.basename(__filename, '.js'));
const ejs = require('ejs');
const { differenceInMilliseconds, parseISO } = require('date-fns');
const fs = require('fs');
const unzipper = require('unzipper');
const fg = require('fast-glob');
const { workspaceFastGlobDefaultOptions } = require('@prairielearn/workspace-utils');
const markdown = require('./markdown');
const config = require('./config');
const csrf = require('./csrf');
const externalGrader = require('./externalGrader');
const { logger } = require('@prairielearn/logger');
const serverJobs = require('./server-jobs');
const ltiOutcomes = require('../lib/ltiOutcomes');
const sqldb = require('@prairielearn/postgres');
const questionServers = require('../question-servers');
const workspaceHelper = require('./workspace');
const issues = require('./issues');
const error = require('@prairielearn/error');
const sql = sqldb.loadSqlEquiv(__filename);
/**
* To improve performance, we'll only render at most three submissions on page
* load. If the user requests more, we'll render them on the fly.
*/
const MAX_RECENT_SUBMISSIONS = 3;
/**
* Internal error type for tracking lack of submission.
*/
class NoSubmissionError extends Error {
constructor(message) {
super(message);
this.name = 'NoSubmissionError';
}
}
module.exports = {
/**
* Internal function, do not call directly. Write the courseIssues for a variant to the DB.
* @protected
*
* @param {Array} courseIssues - List of issue objects for to be written.
* @param {Object} variant - The variant associated with the issues.
* @param {number} authn_user_id - The currently authenticated user.
* @param {string} studentMessage - The message to display to the student.
* @param {Object} courseData - Arbitrary data to be associated with the issues.
* @param {function} callback - A callback(err) function.
*/
_writeCourseIssues(courseIssues, variant, authn_user_id, studentMessage, courseData, callback) {
async.eachSeries(
courseIssues,
async (courseErr) => {
await issues.insertIssueForError(courseErr, {
variantId: variant.id,
studentMessage,
courseData,
authnUserId: authn_user_id,
});
},
(err) => {
if (ERR(err, callback)) return;
callback(null);
}
);
},
/**
* Internal function, do not call directly. Create a variant object, do not write to DB.
* @protected
*
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {Object} options - Options controlling the creation: options = {variant_seed}
* @param {function} callback - A callback(err, courseIssues, variant) function.
*/
_makeVariant(question, course, options, callback) {
debug('_makeVariant()');
var variant_seed;
if (_(options).has('variant_seed') && options.variant_seed != null) {
variant_seed = options.variant_seed;
} else {
variant_seed = Math.floor(Math.random() * Math.pow(2, 32)).toString(36);
}
debug(`_makeVariant(): question_id = ${question.id}`);
questionServers.getModule(question.type, (err, questionModule) => {
if (ERR(err, callback)) return;
questionModule.generate(question, course, variant_seed, (err, courseIssues, data) => {
if (ERR(err, callback)) return;
const hasFatalIssue = _.some(_.map(courseIssues, 'fatal'));
var variant = {
variant_seed: variant_seed,
params: data.params || {},
true_answer: data.true_answer || {},
options: data.options || {},
broken: hasFatalIssue,
};
if (question.workspace_image !== null) {
// if workspace, add graded files to params
variant.params['_workspace_required_file_names'] = (
question.workspace_graded_files || []
).filter((file) => !fg.isDynamicPattern(file, workspaceFastGlobDefaultOptions));
if (!('_required_file_names' in variant.params)) {
variant.params['_required_file_names'] = [];
}
variant.params['_required_file_names'] = variant.params['_required_file_names'].concat(
variant.params['_workspace_required_file_names']
);
}
if (variant.broken) {
return callback(null, courseIssues, variant);
}
questionModule.prepare(question, course, variant, (err, extraCourseIssues, data) => {
if (ERR(err, callback)) return;
courseIssues.push(...extraCourseIssues);
const hasFatalIssue = _.some(_.map(courseIssues, 'fatal'));
var variant = {
variant_seed: variant_seed,
params: data.params || {},
true_answer: data.true_answer || {},
options: data.options || {},
broken: hasFatalIssue,
};
callback(null, courseIssues, variant);
});
});
});
},
/**
* Get a file that is generated by code.
*
* @param {String} filename
* @param {Object} variant - The variant.
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {Number} authn_user_id - The current authenticated user.
* @param {function} callback - A callback(err, fileData) function.
*/
getFile(filename, variant, question, course, authn_user_id, callback) {
questionServers.getModule(question.type, (err, questionModule) => {
if (ERR(err, callback)) return;
questionModule.file(filename, variant, question, course, (err, courseIssues, fileData) => {
if (ERR(err, callback)) return;
const studentMessage = 'Error creating file: ' + filename;
const courseData = { variant, question, course };
module.exports._writeCourseIssues(
courseIssues,
variant,
authn_user_id,
studentMessage,
courseData,
(err) => {
if (ERR(err, callback)) return;
return callback(null, fileData);
}
);
});
});
},
/**
* Internal function, do not call directly. Get a question by either question_id or instance_question_id.
* @protected
*
* @param {?number} question_id - The question for the new variant. Can be null if instance_question_id is provided.
* @param {?number} instance_question_id - The instance question for the new variant. Can be null if question_id is provided.
* @param {function} callback - A callback(err, question) function.
*/
_selectQuestion(question_id, instance_question_id, callback) {
if (question_id != null) {
sqldb.callOneRow('questions_select', [question_id], (err, result) => {
if (ERR(err, callback)) return;
const question = result.rows[0];
callback(null, question);
});
} else {
if (instance_question_id == null) {
return callback(new Error('question_id and instance_question_id cannot both be null'));
}
sqldb.callOneRow(
'instance_questions_select_question',
[instance_question_id],
(err, result) => {
if (ERR(err, callback)) return;
const question = result.rows[0];
callback(null, question);
}
);
}
},
/**
* Internal function, do not call directly. Create a variant object, and write it to the DB.
* @protected
*
* @param {?number} question_id - The question for the new variant. Can be null if instance_question_id is provided.
* @param {?number} instance_question_id - The instance question for the new variant, or null for a floating variant.
* @param {number} user_id - The user for the new variant.
* @param {number} authn_user_id - The current authenticated user.
* @param {boolean} group_work - If the assessment will support group work.
* @param {Object} course - The course for the variant.
* @param {Object} options - Options controlling the creation: options = {variant_seed}
* @param {function} callback - A callback(err, variant) function.
*/
_makeAndInsertVariant(
question_id,
instance_question_id,
user_id,
authn_user_id,
group_work,
course_instance_id,
course,
options,
require_open,
callback
) {
module.exports._selectQuestion(question_id, instance_question_id, (err, question) => {
if (ERR(err, callback)) return;
module.exports._makeVariant(question, course, options, (err, courseIssues, variant) => {
if (ERR(err, callback)) return;
const params = [
variant.variant_seed,
variant.params,
variant.true_answer,
variant.options,
variant.broken,
instance_question_id,
question.id,
course_instance_id,
user_id,
authn_user_id,
group_work,
require_open,
];
sqldb.callOneRow('variants_insert', params, (err, result) => {
if (ERR(err, callback)) return;
const variant = result.rows[0].variant;
debug('variants_insert', variant);
const studentMessage = 'Error creating question variant';
const courseData = { variant, question, course };
module.exports._writeCourseIssues(
courseIssues,
variant,
authn_user_id,
studentMessage,
courseData,
(err) => {
if (ERR(err, callback)) return;
return callback(null, variant);
}
);
});
});
});
},
/**
* Ensure that there is a variant for the given instance question.
*
* @param {?number} question_id - The question for the new variant. Can be null if instance_question_id is provided.
* @param {?number} instance_question_id - The instance question for the new variant, or null for a floating variant.
* @param {number} user_id - The user for the new variant.
* @param {number} authn_user_id - The current authenticated user.
* @param {boolean} group_work - If the assessment will support group work.
* @param {?number} course_instance_id - The course instance for this variant. Can be null for instructor questions.
* @param {Object} course - The course for the variant.
* @param {Object} options - Options controlling the creation: options = {variant_seed}
* @param {boolean} require_open - If true, only use an existing variant if it is open.
* @param {function} callback - A callback(err, variant) function.
*/
ensureVariant(
question_id,
instance_question_id,
user_id,
authn_user_id,
group_work,
course_instance_id,
course,
options,
require_open,
callback
) {
if (instance_question_id != null) {
// see if we have a useable existing variant, otherwise
// make a new one
var params = [instance_question_id, require_open];
sqldb.call('instance_questions_select_variant', params, (err, result) => {
if (ERR(err, callback)) return;
const variant = result.rows[0].variant;
if (variant != null) {
debug('instance_questions_select_variant not null', variant);
return callback(null, variant);
}
module.exports._makeAndInsertVariant(
question_id,
instance_question_id,
user_id,
authn_user_id,
group_work,
course_instance_id,
course,
options,
require_open,
(err, variant) => {
if (ERR(err, callback)) return;
debug(
'instance_questions_select_variant was null, run through _makeAndInsertVariant',
variant
);
callback(null, variant);
}
);
});
} else {
// if we don't have instance_question_id, just make a new variant
module.exports._makeAndInsertVariant(
question_id,
instance_question_id,
user_id,
authn_user_id,
group_work,
course_instance_id,
course,
options,
require_open,
(err, variant) => {
if (ERR(err, callback)) return;
callback(null, variant);
}
);
}
},
/**
* Save a new submission to a variant into the database.
*
* @param {Object} submission - The submission to save (should not have an id property yet).
* @param {Object} variant - The variant to submit to.
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {function} callback - A callback(err, submission_id) function.
*/
saveSubmission(submission, variant, question, course, callback) {
debug('saveSubmission()');
submission.raw_submitted_answer = submission.submitted_answer;
submission.gradable = true;
let questionModule, courseIssues, data, submission_id, workspace_id, zipPath;
async.series(
[
(callback) => {
// if workspace, get workspace_id
if (question.workspace_image != null) {
const params = {
variant_id: submission.variant_id,
};
sqldb.queryZeroOrOneRow(sql.select_workspace_id, params, (err, result) => {
if (ERR(err, callback)) return;
if (result.rowCount > 0) {
workspace_id = result.rows[0].workspace_id;
}
callback(null);
});
} else {
callback(null);
}
},
async () => {
// if we have a workspace and any files to be graded, get the files
if (workspace_id == null || !question.workspace_graded_files?.length) {
debug('saveSubmission()', 'not getting workspace graded files');
return;
}
try {
zipPath = await workspaceHelper.getGradedFiles(workspace_id);
debug('saveSubmission()', `saved graded files: ${zipPath}`);
} catch (err) {
if (err instanceof workspaceHelper.SubmissionFormatError) {
((submission.format_errors ??= {})._files ??= []).push(err.message);
} else {
throw err;
}
}
},
async () => {
// if we have workspace files, encode them into _files
if (zipPath == null) return;
const zip = fs.createReadStream(zipPath).pipe(unzipper.Parse({ forceStream: true }));
if (!('_files' in submission.submitted_answer)) {
submission.submitted_answer['_files'] = [];
}
for await (const zipEntry of zip) {
const name = zipEntry.path;
const contents = (await zipEntry.buffer()).toString('base64');
submission.submitted_answer['_files'].push({ name, contents });
}
await fs.promises.unlink(zipPath);
},
(callback) => {
questionServers.getModule(question.type, (err, ret_questionModule) => {
if (ERR(err, callback)) return;
questionModule = ret_questionModule;
debug('saveSubmission()', 'loaded questionModule');
callback(null);
});
},
(callback) => {
questionModule.parse(
submission,
variant,
question,
course,
(err, ret_courseIssues, ret_data) => {
if (ERR(err, callback)) return;
courseIssues = ret_courseIssues;
data = ret_data;
debug('saveSubmission()', 'completed parse()');
callback(null);
}
);
},
(callback) => {
const studentMessage = 'Error parsing submission';
const courseData = { variant, question, submission, course };
module.exports._writeCourseIssues(
courseIssues,
variant,
submission.auth_user_id,
studentMessage,
courseData,
(err) => {
if (ERR(err, callback)) return;
debug('saveSubmission()', `wrote courseIssues: ${courseIssues.length}`);
callback(null);
}
);
},
(callback) => {
const hasFatalIssue = _.some(_.map(courseIssues, 'fatal'));
if (hasFatalIssue) data.gradable = false;
data.broken = hasFatalIssue;
const params = [
data.submitted_answer,
data.raw_submitted_answer,
data.format_errors,
data.gradable,
data.broken,
data.true_answer,
false, // regradable
submission.credit,
submission.mode,
submission.variant_id,
submission.auth_user_id,
];
sqldb.callOneRow('submissions_insert', params, (err, result) => {
if (ERR(err, callback)) return;
submission_id = result.rows[0].submission_id;
debug('saveSubmission()', 'inserted', 'submission_id:', submission_id);
callback(null);
});
},
],
(err) => {
if (ERR(err, callback)) return;
debug('saveSubmission()', 'returning', 'submission_id:', submission_id);
callback(null, submission_id);
}
);
},
/**
* Grade the most recent submission for a given variant.
*
* @param {Object} variant - The variant to grade.
* @param {?number} check_submission_id - The submission_id that must be graded (or null to skip this check).
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {number} authn_user_id - The currently authenticated user.
* @param {boolean} overrideGradeRateCheck - Whether to override grade rate limits.
* @param {function} callback - A callback(err) function.
*/
gradeVariant(
variant,
check_submission_id,
question,
course,
authn_user_id,
overrideGradeRateCheck,
callback
) {
debug('_gradeVariant()');
let questionModule, courseIssues, data, submission, grading_job;
async.series(
[
(callback) => {
var params = [variant.id, check_submission_id];
sqldb.callZeroOrOneRow(
'variants_select_submission_for_grading',
params,
(err, result) => {
if (ERR(err, callback)) return;
if (result.rowCount === 0) return callback(new NoSubmissionError());
submission = result.rows[0];
debug('_gradeVariant()', 'selected submission', 'submission.id:', submission.id);
callback(null);
}
);
},
(callback) => {
if (overrideGradeRateCheck) return callback(null);
var params = [variant.instance_question_id];
sqldb.callZeroOrOneRow('instance_questions_next_allowed_grade', params, (err, result) => {
if (ERR(err, callback)) return;
debug(
'_gradeVariant()',
'checked grade rate',
'allow_grade_left_ms:',
result.rows[0].allow_grade_left_ms
);
if (result.rows[0].allow_grade_left_ms > 0) return callback(new NoSubmissionError());
callback(null);
});
},
(callback) => {
const params = [submission.id, authn_user_id];
sqldb.callOneRow('grading_jobs_insert', params, (err, result) => {
if (ERR(err, callback)) return;
grading_job = result.rows[0];
debug('_gradeVariant()', 'inserted', 'grading_job.id:', grading_job.id);
callback(null);
});
},
(callback) => {
questionServers.getModule(question.type, (err, ret_questionModule) => {
if (ERR(err, callback)) return;
questionModule = ret_questionModule;
debug('_gradeVariant()', 'loaded questionModule');
callback(null);
});
},
(callback) => {
if (question.grading_method !== 'External') {
// For Internal grading we call the grading code. For Manual grading, if the question
// reached this point, it has auto points, so it should be treated like Internal.
questionModule.grade(
submission,
variant,
question,
course,
(err, ret_courseIssues, ret_data) => {
if (ERR(err, callback)) return;
courseIssues = ret_courseIssues;
data = ret_data;
const hasFatalIssue = _.some(_.map(courseIssues, 'fatal'));
if (hasFatalIssue) data.gradable = false;
data.broken = hasFatalIssue;
debug('_gradeVariant()', 'completed grade()', 'hasFatalIssue:', hasFatalIssue);
callback(null);
}
);
} else {
// for External grading we don't do anything
courseIssues = [];
data = {};
callback(null);
}
},
(callback) => {
const studentMessage = 'Error grading submission';
const courseData = { variant, question, submission, course };
module.exports._writeCourseIssues(
courseIssues,
variant,
submission.auth_user_id,
studentMessage,
courseData,
(err) => {
if (ERR(err, callback)) return;
debug('_gradeVariant()', `wrote courseIssues: ${courseIssues.length}`);
callback(null);
}
);
},
(callback) => {
if (question.grading_method === 'External') {
// We haven't actually graded this question yet - don't attempt
// to update the grading job or submission.
return callback(null);
}
const params = [
grading_job.id,
// `received_time` and `start_time` were already set when the
// grading job was inserted, so they'll remain unchanged.
// `finish_time` will be set to `now()` by this sproc.
null, // received_time
null, // start_time
null, // finish_time
data.submitted_answer,
data.format_errors,
data.gradable,
data.broken,
data.params,
data.true_answer,
data.feedback,
data.partial_scores,
data.score,
data.v2_score,
];
sqldb.callOneRow('grading_jobs_update_after_grading', params, (err, result) => {
if (ERR(err, callback)) return;
// If the submission was marked invalid during grading the grading
// job will be marked ungradable and we should bail here to prevent
// LTI updates.
grading_job = result.rows[0];
if (!grading_job.gradable) return callback(new NoSubmissionError());
debug('_gradeVariant()', 'inserted', 'grading_job.id:', grading_job.id);
callback(null);
});
},
(callback) => {
sqldb.queryOneRow(
sql.select_assessment_for_submission,
{ submission_id: submission.id },
(err, result) => {
if (ERR(err, callback)) return;
let assessment_instance_id = result.rows[0].assessment_instance_id;
ltiOutcomes.updateScore(assessment_instance_id, (err) => {
if (ERR(err, callback)) return;
callback(null);
});
}
);
},
],
(err) => {
// catch NoSubmissionError as we are just using it to exit with no action
if (err instanceof NoSubmissionError) {
debug('_gradeVariant()', 'no submissions for grading, skipping');
err = null;
}
if (ERR(err, callback)) return;
debug('_gradeVariant()', 'success');
// data and grading_job might not be defined if we bailed out early above
if (data && !data.broken && grading_job && grading_job.grading_method === 'External') {
// We need to submit this external grading job.
externalGrader.beginGradingJob(grading_job.id, (err) => {
if (ERR(err, callback)) return;
callback(null);
});
} else {
callback(null);
}
}
);
},
/**
* Save and grade a new submission to a variant.
*
* @param {Object} submission - The submission to save (should not have an id property yet).
* @param {Object} variant - The variant to submit to.
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {boolean} overrideGradeRateCheck - Whether to override grade rate limits.
* @param {function} callback - A callback(err, submission_id) function.
*/
saveAndGradeSubmission(submission, variant, question, course, overrideGradeRateCheck, callback) {
debug('saveAndGradeSubmission()');
let submission_id, grading_job_id;
async.series(
[
(callback) => {
module.exports.saveSubmission(
submission,
variant,
question,
course,
(err, ret_submission_id) => {
if (ERR(err, callback)) return;
submission_id = ret_submission_id;
debug('saveAndGradeSubmission()', 'submission_id:', submission_id);
callback(null);
}
);
},
(callback) => {
module.exports.gradeVariant(
variant,
submission_id,
question,
course,
submission.auth_user_id,
overrideGradeRateCheck,
(err, ret_grading_job_id) => {
if (ERR(err, callback)) return;
grading_job_id = ret_grading_job_id;
debug('saveAndGradeSubmission()', 'graded');
callback(null);
}
);
},
],
(err) => {
if (ERR(err, callback)) return;
debug('saveAndGradeSubmission()', 'returning submission_id:', submission_id);
if (grading_job_id !== undefined) {
// We need to submit this grading job now that the
// transaction has been committed
externalGrader.beginGradingJob(grading_job_id, (err) => {
if (ERR(err, callback)) return;
callback(null, submission_id);
});
} else {
// We're done!
callback(null, submission_id);
}
}
);
},
/**
* Internal worker for testVariant(). Do not call directly.
* @protected
*
* @param {Object} variant - The variant to submit to.
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {string} test_type - The type of test to run. Should be one of 'correct', 'incorrect', or 'invalid'.
* @param {number} authn_user_id - The currently authenticated user.
* @param {function} callback - A callback(err, submission_id) function.
*/
_createTestSubmission(variant, question, course, test_type, authn_user_id, callback) {
debug('_createTestSubmission()');
if (question.type !== 'Freeform') return callback(new Error('question.type must be Freeform'));
let questionModule, courseIssues, data, submission_id, grading_job;
async.series(
[
(callback) => {
questionServers.getModule(question.type, (err, ret_questionModule) => {
if (ERR(err, callback)) return;
questionModule = ret_questionModule;
debug('_createTestSubmission()', 'loaded questionModule');
callback(null);
});
},
(callback) => {
questionModule.test(
variant,
question,
course,
test_type,
(err, ret_courseIssues, ret_data) => {
if (ERR(err, callback)) return;
courseIssues = ret_courseIssues;
data = ret_data;
const hasFatalIssue = _.some(_.map(courseIssues, 'fatal'));
data.broken = hasFatalIssue;
debug('_createTestSubmission()', 'completed test()');
callback(null);
}
);
},
(callback) => {
const studentMessage = 'Error creating test submission';
const courseData = { variant, question, course };
module.exports._writeCourseIssues(
courseIssues,
variant,
authn_user_id,
studentMessage,
courseData,
(err) => {
if (ERR(err, callback)) return;
debug('_createTestSubmission()', `wrote courseIssues: ${courseIssues.length}`);
callback(null);
}
);
},
(callback) => {
const hasFatalIssue = _.some(_.map(courseIssues, 'fatal'));
if (hasFatalIssue) data.gradable = false;
const params = [
{}, // submitted_answer
data.raw_submitted_answer,
data.format_errors,
data.gradable,
data.broken,
// The `test` phase is not allowed to mutate `correct_answers`
// (aliased here to `true_answer`), so we just pick the original
// `true_answer` so we can use our standard `submissions_insert`
// sproc.
variant.true_answer,
true, // regradable
null, // credit
null, // mode
variant.id,
authn_user_id,
];
sqldb.callOneRow('submissions_insert', params, (err, result) => {
if (ERR(err, callback)) return;
submission_id = result.rows[0].submission_id;
debug('_createTestSubmission()', 'inserted', 'submission_id:', submission_id);
callback(null);
});
},
(callback) => {
const params = [submission_id, authn_user_id];
sqldb.callOneRow('grading_jobs_insert', params, (err, result) => {
if (ERR(err, callback)) return;
grading_job = result.rows[0];
debug('_createTestSubmission()', 'inserted', 'grading_job_id:', grading_job.id);
callback(null);
});
},
(callback) => {
const params = [
grading_job.id,
null, // received_time
null, // start_time
null, // finish_tim
{}, // submitted_answer
data.format_errors,
data.gradable,
data.broken,
data.params,
data.true_answer,
data.feedback,
data.partial_scores,
data.score,
null, // v2_score
];
sqldb.callOneRow('grading_jobs_update_after_grading', params, (err, result) => {
if (ERR(err, callback)) return;
grading_job = result.rows[0];
debug('_createTestSubmission()', 'inserted', 'grading_job.id:', grading_job.id);
callback(null);
});
},
],
(err) => {
if (ERR(err, callback)) return;
debug('_createTestSubmission()', 'returning', 'submission_id:', submission_id);
callback(null, submission_id);
}
);
},
/**
* Internal worker for testVariant(). Do not call directly.
* @protected
*
* @param {Object} expected_submission - Generated reference submission data.
* @param {Object} test_submission - Computed submission to be tested.
* @param {function} callback - A callback(err, courseIssues) function.
*/
_compareSubmissions(expected_submission, test_submission, callback) {
const courseIssues = [];
const checkEqual = (name, var1, var2) => {
const json1 = jsonStringifySafe(var1);
const json2 = jsonStringifySafe(var2);
if (!_.isEqual(var1, var2)) {
courseIssues.push(new Error(`"${name}" mismatch: expected "${json1}" but got "${json2}"`));
}
};
if (expected_submission.broken) {
courseIssues.push(new Error('expected_submission is broken, skipping tests'));
return callback(null, courseIssues);
}
if (test_submission.broken) {
courseIssues.push(new Error('test_submission is broken, skipping tests'));
return callback(null, courseIssues);
}
checkEqual('gradable', expected_submission.gradable, test_submission.gradable);
checkEqual(
'format_errors keys',
Object.keys(expected_submission.format_errors),
Object.keys(test_submission.format_errors)
);
if (!test_submission.gradable || !expected_submission.gradable) {
return callback(null, courseIssues);
}
checkEqual(
'partial_scores',
expected_submission.partial_scores,
test_submission.partial_scores
);
checkEqual('score', expected_submission.score, test_submission.score);
callback(null, courseIssues);
},
/**
* Internal worker for _testQuestion(). Do not call directly.
* Tests a question variant. Issues will be inserted into the issues table.
* @protected
*
* @param {Object} variant - The variant to submit to.
* @param {Object} question - The question for the variant.
* @param {Object} course - The course for the variant.
* @param {string} test_type - The type of test to run. Should be one of 'correct', 'incorrect', or 'invalid'.
* @param {number} authn_user_id - The currently authenticated user.
* @param {function} callback - A callback(err) function.
*/
_testVariant(variant, question, course, test_type, authn_user_id, callback) {
debug('_testVariant()');
let expected_submission_id, expected_submission, test_submission_id, test_submission;
async.series(
[
(callback) => {
module.exports._createTestSubmission(
variant,
question,
course,
test_type,
authn_user_id,
(err, ret_submission_id) => {
if (ERR(err, callback)) return;
expected_submission_id = ret_submission_id;
debug('_testVariant()', 'expected_submission_id:', expected_submission_id);
callback(null);
}
);
},
(callback) => {
sqldb.callOneRow('submissions_select', [expected_submission_id], (err, result) => {
if (ERR(err, callback)) return;
expected_submission = result.rows[0];
debug('_testVariant()', 'selected expected_submission, id:', expected_submission.id);
callback(null);
});
},
(callback) => {
const submission = {
variant_id: variant.id,
auth_user_id: authn_user_id,
submitted_answer: expected_submission.raw_submitted_answer,
};
module.exports.saveSubmission(
submission,
variant,
question,
course,
(err, ret_submission_id) => {
if (ERR(err, callback)) return;
test_submission_id = ret_submission_id;
debug('_testVariant()', 'test_submission_id:', test_submission_id);
callback(null);
}
);
},
(callback) => {
module.exports.gradeVariant(
variant,
test_submission_id,
question,
course,
authn_user_id,
true,
(err) => {
if (ERR(err, callback)) return;
debug('testVariant()', 'graded');
callback(null);
}
);
},
(callback) => {
sqldb.callOneRow('submissions_select', [test_submission_id], (err, result) => {
if (ERR(err, callback)) return;
test_submission = result.rows[0];
debug('_testVariant()', 'selected test_submission, id:', test_submission.id);
callback(null);
});
},
(callback) => {
module.exports._compareSubmissions(
expected_submission,
test_submission,
(err, courseIssues) => {
if (ERR(err, callback)) return;