Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for external grading directory construction #1490

Open
nwalters512 opened this issue Apr 21, 2019 · 0 comments
Open

Write tests for external grading directory construction #1490

nwalters512 opened this issue Apr 21, 2019 · 0 comments
Labels
enhancement A desired new feature or change (not a bug)
Projects

Comments

@nwalters512
Copy link
Contributor

The root cause of #1489 could have been caught if we had test about the lib/externalGraderCommon.js#buildDirectory function. That function is "pure" in that it just takes a bunch of objects and builds a directory on disk from them - it doesn't read from or write to the DB (although it does read some files from disk). Given that, it should be relatively easy to test in isolation.

@mwest1066 mwest1066 added the enhancement A desired new feature or change (not a bug) label Mar 28, 2020
@mwest1066 mwest1066 added this to Developer experience in Development Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A desired new feature or change (not a bug)
Projects
Development
Developer experience
Development

No branches or pull requests

2 participants