You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When Large font sizes selected in the system settings Hour/Minute labels become clipped in timepicker.
Large font size on emulator (Pixel 5 API 31) is not enough to cause the problem, but on Samsung phone (Android 10) you can choose larger font size, which causes clipping.
Buttons are clipped as well.
To Reproduce
Steps to reproduce the behaviour (including any applicable code):
Go to Android Settings -> Display -> Font size and style
Select largest font
Open timepicker dialog in demo app
See error
Expected behaviour
Text Should not clip
Screenshots
Device:
Name: Samsung Galaxy A21
Android Version: Android 10
Suggestion
May be it is possible to just set text size of H/M/: labels in Dp instead - field is large enough that it is bigger than the biggest font size selectable, so should not be a problem from accessibility point of view. 60-65.dp seem to work well (at least on non-small devices)
For Buttons - the opposite - set defaultButtonHeight in MaterialDialogScope.DialogButtonsLayout to 36.sp rather than 36.dp.
The text was updated successfully, but these errors were encountered:
Describe the bug
When Large font sizes selected in the system settings Hour/Minute labels become clipped in timepicker.
Large font size on emulator (Pixel 5 API 31) is not enough to cause the problem, but on Samsung phone (Android 10) you can choose larger font size, which causes clipping.
Buttons are clipped as well.
To Reproduce
Steps to reproduce the behaviour (including any applicable code):
Expected behaviour
Text Should not clip
Screenshots
![Screenshot_20221011-112435_compose-material-dialogs](https://user-images.githubusercontent.com/457326/194964784-cced88d5-d0d3-4327-930b-14888d67da89.png)
Device:
Suggestion
May be it is possible to just set text size of H/M/: labels in Dp instead - field is large enough that it is bigger than the biggest font size selectable, so should not be a problem from accessibility point of view. 60-65.dp seem to work well (at least on non-small devices)
For Buttons - the opposite - set
defaultButtonHeight
inMaterialDialogScope.DialogButtonsLayout
to 36.sp rather than 36.dp.The text was updated successfully, but these errors were encountered: