Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using MaterialTheme in the library's code #168

Open
Nek-12 opened this issue Oct 28, 2022 · 0 comments · May be fixed by #169
Open

Stop using MaterialTheme in the library's code #168

Nek-12 opened this issue Oct 28, 2022 · 0 comments · May be fixed by #169
Assignees
Labels
bug Something isn't working

Comments

@Nek-12
Copy link

Nek-12 commented Oct 28, 2022

Describe the bug
Stop using MaterialTheme because that leads to hardcoded material theme values throughout the library.
I discovered this issue while trying to override all colors and shapes of the dialogs for Material3 migration. I discovered that many usages of MaterialTheme (from material2) are found inside the library's internal code.

To Reproduce

  1. Use Material3 and remove material2 AppTheme() from the composition
  2. Watch your dialogs get broken without a way to override all colors.
    Example of hardcoded properties: Shapes and ":" text color and style of the Time Picker dialog.

Expected behaviour
When I provide the picker with colors, they must be actually used, not just for the sake of it.

Screenshots
Untitled

@Nek-12 Nek-12 added the bug Something isn't working label Oct 28, 2022
@PranavMaganti PranavMaganti linked a pull request Dec 18, 2022 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants