Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Crossover Review Ticket #13

Open
PranavP04 opened this issue Feb 27, 2023 · 2 comments
Open

Final Crossover Review Ticket #13

PranavP04 opened this issue Feb 27, 2023 · 2 comments

Comments

@PranavP04
Copy link
Owner

PranavP04 commented Feb 27, 2023

Items Self Ritvik Keerthi Andrew Meng Avg
Individual Attendance, Capture the Moment: 2 points 2 2 2 2
Team Presentation to Teacher: 3 points (1 minute), 3 3 3 3
Project quality, running cross domain and no crashes on FE to BE with these reviews 1 1 1 1
UI contains inputs that are validated for garbage, data cleaned (ie validate DOB or Password) 1 1 1 1
UI contains actions for Create, Read, 1 1 1 1
UI contains actions for Update, Delete 1 1 1 1
JWT is guarding a feature, demonstration of cookies 0 0 0 0
Project quality, observation of comments in every function, class, or method reviewed. Be sure to review POJO, API Controller, and JPA. 1 1 1 1
BE contains and API that shows that it handles error conditions (ie duplicate user id) 1 1 1 1
BE contains support for GET and POST methods 1 1 1 1
BE contains a database that supports Create, Read 1 1 1 1
BE contains a database that supports Update, Delete 1 1 1 1
Purpose/Theme/Quality. .5 .5 .5 .5
Video .5 0.5 .5 .5
Runtime Links .5 .5 .5 .5
README.md .5 .5 .5 .5
Blog, Guides for review 5. 0.5 .5 .5
75% of individuals have met full stack work. .5 .5 .5 .5
Individual Review Ticket .5 .5 .5 .5
GitHub analytics .5 .5 .5 .5
Runtime Links .5 .5 .5 .5
Technical Accomplishments .5 .5 .5 .5
Blog, Guides for review .5 .5 .5 .5
Meeting full stack and backend objectives .5 .5 .5 .5
Total Score: 18/20 18/20 18/20 18/20
API Controller
image
image
image
API Controller
image
@Ritvik-Keerthi
Copy link

Ritvik-Keerthi commented Feb 27, 2023

Night of the Museum- 5/5
Individual score for runtime - 5/5

runs very smoothly
Data is clear
CRUD stuff met
JWT login token is good
Individual Score for Code Review - 5/5

good quality project
errors handled very well
BE contains GET and POST
create, read, update, delete all met
Crossover Grade - 9.5/10

Silent Review - 1/3

  • doesn't have video

Final Score: 17.5/20

@supermengman
Copy link

supermengman commented Feb 27, 2023

Night at the Museum: 5/5

  • pictures of behind the scenes
  • frontend/backend debugging

Live Review:
Individual Score for Runtime: 5/5

  • no crashing
  • validate input for login
  • JWT for login
  • create/read user info
  • update delete recipes

Code Review: 4/5

  • error handling/exception handling in API controllers
  • GET/POST for user login
  • database CRUD user information/recipe info

Silent Review:
Team Review: 1/3

  • runtime links
  • full stack most individuals

Individual Review: 1/2

  • review ticket exists
  • full stack/backend objectives

Total: 17/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants