Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow: Release #14

Merged
merged 3 commits into from Mar 6, 2021
Merged

Conversation

majabojarska
Copy link
Collaborator

Closes #5.

Changes:

  • Add GitHub Actions workflow "Release". Runs on tag push, named v* (e.g. v1.0.5). This workflow creates a GitHub release and publishes the package to PyPI repository.
  • Change setup.py manual versioning to SCM versioning - the tag's version determines the package's version. This means that tag v1.0.5 results in package version 1.0.5 on PyPI. This also means that the package version won't be maintained via source code, but via Git tags.
  • Requires package maintainer to create PyPI API token and add it to the project's "secrets" as PYPI_API_TOKEN. See encrypted secrets page for details on how to do it.

@Prayag2
Copy link
Owner

Prayag2 commented Mar 6, 2021

Please update your repo. There were some important bug fixes.

@majabojarska
Copy link
Collaborator Author

Rebased the changes onto latest changes upstream master branch.

@Prayag2
Copy link
Owner

Prayag2 commented Mar 6, 2021

Thanks!

@Prayag2 Prayag2 merged commit 52d173e into Prayag2:master Mar 6, 2021
@Prayag2
Copy link
Owner

Prayag2 commented Mar 6, 2021

I've added the PYPI_API_TOKEN as a "secret" in the repository.

@Prayag2
Copy link
Owner

Prayag2 commented Mar 6, 2021

I don't know why but it's not working:
SS_2021-03-06_18-33-23

@Prayag2
Copy link
Owner

Prayag2 commented Mar 6, 2021

Anyways, I fixed it by removing the "release" workflow and keeping only the "deploy" workflow. I always use the "draft a new release" button in GitHub to create new releases so there was no need for the "release" workflow.

@majabojarska
Copy link
Collaborator Author

majabojarska commented Mar 6, 2021

Yes, the "Release" step will fail if a release already exists. If you prefer to use draft releases manually that's also fine 👍.

@majabojarska majabojarska deleted the gh_workflow_deploy branch March 6, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make konsave a PyPI-ready package
2 participants