Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Facebook Watch icon #6511

Closed
PhilMinecraft opened this issue Jul 26, 2022 · 10 comments · Fixed by #6556
Closed

Change the Facebook Watch icon #6511

PhilMinecraft opened this issue Jul 26, 2022 · 10 comments · Fixed by #6556
Assignees
Labels
feature request New feature for an existing Presence

Comments

@PhilMinecraft
Copy link

Presence name

Facebook

Description

Facebook Watch has its own dedicated icon, it doesn't fit if you just put Facebook on the logo alongside with the "Facebook Watch" name

Alternatives

Change Facebook logo into Facebook Watch logo if I'm browsing or watching Facebook Watch contents

Additional context

image
svgexport-6

@PhilMinecraft PhilMinecraft added the feature request New feature for an existing Presence label Jul 26, 2022
@RisingSunLight42
Copy link
Contributor

If not done today, I'll add it tomorrow

@Slowlife01
Copy link
Contributor

Kinda, only the clearActivity() function is broken

@PhilMinecraft
Copy link
Author

PhilMinecraft commented Jul 30, 2022

If not done today, I'll add it tomorrow

ok it's been 3 days, where is it now?
image
I put the Facebook Watch SVG icon on the bottom of the screenshot, use it for the presence's icon

@RisingSunLight42
Copy link
Contributor

Yup, that's why I didn't add it. We need to wait for the creator to make an update for this to work fine.

@RisingSunLight42
Copy link
Contributor

I've seen on #6552 that we can put imgur link in the largeImageKey value. Maybe we can do this way for this case?
Idk if this is fine, @EncryptedDev what do you think of that?

@EncryptedDev
Copy link
Contributor

I've seen on #6552 that we can put imgur link in the largeImageKey value. Maybe we can do this way for this case?
Idk if this is fine, @EncryptedDev what do you think of that?

Yep, you can

@RisingSunLight42
Copy link
Contributor

Perfect, so I take this issue, I'll create the PR to add the icon in the next hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature for an existing Presence
Development

Successfully merging a pull request may close this issue.

5 participants
@Slowlife01 @EncryptedDev @PhilMinecraft @RisingSunLight42 and others