Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latex format fails to copy external directory #619

Closed
StevenClontz opened this issue Oct 12, 2023 · 4 comments · Fixed by #620
Closed

latex format fails to copy external directory #619

StevenClontz opened this issue Oct 12, 2023 · 4 comments · Fixed by #620

Comments

@StevenClontz
Copy link
Member

To replicate:

pretext new
cd new-pretext-project
mkdir assets
touch assets/foo.txt
pretext build print-latex # no external directory is copied!
@StevenClontz
Copy link
Member Author

I looked back and found where we used to handle this:

# core script doesn't put a copy of images in output for latex builds, so we do it instead here

I guess maybe this got forgotten in the 2.0 refactor? Though I'm unclear why generated is being copied but external is not.

@StevenClontz
Copy link
Member Author

I guess maybe this got forgotten in the 2.0 refactor? Though I'm unclear why generated is being copied but external is not.

For posterity: I don't think generated was being copied, actually.

@oscarlevin
Copy link
Member

It looks like we should manage directories in the CLI. Should this also be done for the custom target???

@StevenClontz
Copy link
Member Author

Yeah, I think we should run core.get_managed_directories and core.manage_directories (once it exists) to put files where our users will expect them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants