Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing log output #689

Closed
siefkenj opened this issue Feb 25, 2024 · 5 comments
Closed

Confusing log output #689

siefkenj opened this issue Feb 25, 2024 · 5 comments

Comments

@siefkenj
Copy link
Contributor

On the command line, the CLI outputs

comprehensive messages, warnings, and errors:

even if there are no errors. At first glance, I see the word error and I think something has gone wrong. I don't think this text is helpful. A blank line would serve just as well to separate it from the previous diagnostic information.

@StevenClontz
Copy link
Member

I think that line is printed before we know if there are errors (which I think we basically pipe through from core PreTeXt). So I'm in favor of this but am not sure how trivial the change is.

@siefkenj
Copy link
Contributor Author

Hmm. It sounds like pretext core should switch to using streams to send messages. That way they can be captured by the CLI and pretty-printed/filtered

@oscarlevin
Copy link
Member

Perhaps core could report "None" when there are none. But this is definitely an issue that belongs with core, not the CLI.

@rbeezer
Copy link
Collaborator

rbeezer commented Mar 5, 2024

@oscarlevin is right that this is not CLI territory, but rather for PreTeXt.

I have

  • softened the lead-in message to the log
  • made it appear only when there are messages to be seen

See PreTeXtBook/pretext@512775a

I'm not sure just where/how to best report a None. Perhaps a good Drop-In discussion with @oscarlevin?

@rbeezer
Copy link
Collaborator

rbeezer commented Mar 5, 2024

Forgot to say: thanks @siefkenj for the report, much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants