Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pndev doctor does not add config file #6

Open
3 tasks
typeoneerror opened this issue Oct 8, 2019 · 4 comments
Open
3 tasks

pndev doctor does not add config file #6

typeoneerror opened this issue Oct 8, 2019 · 4 comments
Assignees

Comments

@typeoneerror
Copy link
Contributor

typeoneerror commented Oct 8, 2019

The README indicate it should add one if it does not exist.

Looks like the config file is named differently than README indicates.

https://github.com/PrecisionNutrition/pndev/blob/master/src/config.rs#L20

  • create config file when doctor is ruin
  • make sure config file name is accurate
  • should we use ~/.config/pndev_config?
@typeoneerror typeoneerror self-assigned this Oct 8, 2019
@ghedamat
Copy link
Collaborator

ghedamat commented Oct 8, 2019

@typeoneerror the reason why I don't have .pndev_config.toml is because it seemed like the confy crate is adding .toml on its own

this def works in my build but clearly doesn't work for you?

would love to see the behavior on your system

I'm down for moving the file in ~/.config/pndev_config.toml

@typeoneerror
Copy link
Contributor Author

Cool, I can investigate.

@ghedamat
Copy link
Collaborator

ghedamat commented Oct 8, 2019

@typeoneerror ok so ,
it does create the file properly

but NOT when you run doctor,
you have to run pndev clone or any other commands that requires the directory to be there like pndev ps pndev start pndev stop

I must have deleted the line for doctor while coding on the plane

@ghedamat
Copy link
Collaborator

ghedamat commented Oct 8, 2019

and the file will be created as ~/pndev_config.toml

so you could have a pr that

  • moves it to .config
  • does NOT add .toml as that's added automatically
  • updates README
  • ensures we load the config for the doctor command

let me know if you get stuck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants