Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to make install possible #1

Merged
merged 2 commits into from Aug 11, 2022

Conversation

fsahli
Copy link
Collaborator

@fsahli fsahli commented Aug 10, 2022

We were trying to use JAX-BO for a project but it has two issues that made installation fail:

  • there was a syntax error in one of the models
  • the index_update function of JAX was deprecated, so I required in setup.py an older version of jax and jaxlib. Long term should be better to update the code to make it work with the current version of JAX.

@fsahli fsahli requested a review from paraklas August 10, 2022 14:12
@paraklas
Copy link
Collaborator

Thanks for spotting these Francisco!

Re: index_update, I think it's better to update the code to use x = x.at[idx].set(y) to make things compatible with the latest versions of jax and jaxlib.

@fsahli fsahli merged commit 17cf9d6 into PredictiveIntelligenceLab:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants