Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Prefect Icons bloating css #110

Closed
pleek91 opened this issue Nov 5, 2021 · 1 comment · Fixed by #115
Closed

Prefect Icons bloating css #110

pleek91 opened this issue Nov 5, 2021 · 1 comment · Fixed by #115

Comments

@pleek91
Copy link
Collaborator

pleek91 commented Nov 5, 2021

For some reason the prefect the icon files are being inlined in the css output. This causes the dist/style.css to be very large (over 3 mb). My assumption is that this is inefficient as the browser should be able to determine which file it should download. Since all 3 are inlined every browser is effectively downloading all 3 but only using one.

@pleek91
Copy link
Collaborator Author

pleek91 commented Nov 8, 2021

Appears to be a bug in vite's lib mode that prevents it from exporting static assets. Seems like there's some agreement on that it should be fixed but hasn't been. vitejs/vite#3295

From my testing putting the fonts in the public folder fixes the build issue. This should be enough for now. This could be revisited when that vite issue is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant