Feature: ready to support flags defined in orion-design #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackoverfloweth
requested review from
marichka-offen,
znicholasbrown,
zhen0,
brandonreid,
space-age-pete and
nicolascribbles
as code owners
✅ Deploy Preview for orion-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pleek91
reviewed
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this puts down the framework to define flags in orion-design (as well as in nebula/orion-ui still).
flags can be defined in orion-design if they are planned to be implemented in both nebula and orion-ui
defining a can in nebula will be the combination of
defining a can in orion-ui will be the combination of