-
Notifications
You must be signed in to change notification settings - Fork 1.5k
/
test_cloud_task_runner.py
1054 lines (855 loc) · 35 KB
/
test_cloud_task_runner.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
import datetime
import json
from unittest.mock import MagicMock
import pendulum
import pytest
from dask.base import tokenize
import prefect
from prefect.client import Client
from prefect.core import Edge, Task
from prefect.engine.cache_validators import all_inputs, duration_only
from prefect.engine.cloud import CloudTaskRunner
from prefect.engine.result import Result
from prefect.engine.results import LocalResult, PrefectResult, SecretResult
from prefect.engine.runner import ENDRUN
from prefect.engine.signals import LOOP
from prefect.engine.state import (
Cached,
Cancelled,
ClientFailed,
Failed,
Finished,
Looped,
Mapped,
Paused,
Pending,
Queued,
Retrying,
Running,
Skipped,
Success,
TimedOut,
TriggerFailed,
)
from prefect.utilities.configuration import set_temporary_config
from prefect.exceptions import VersionLockMismatchSignal
@pytest.fixture(autouse=True)
def cloud_settings():
with set_temporary_config(
{
"engine.flow_runner.default_class": "prefect.engine.cloud.CloudFlowRunner",
"engine.task_runner.default_class": "prefect.engine.cloud.CloudTaskRunner",
"cloud.auth_token": "token",
}
):
yield
@pytest.fixture()
def client(monkeypatch):
cloud_client = MagicMock(
get_flow_run_info=MagicMock(return_value=MagicMock(state=None)),
set_flow_run_state=MagicMock(),
get_task_run_info=MagicMock(return_value=MagicMock(state=None)),
set_task_run_state=MagicMock(
side_effect=lambda task_run_id, version, state, cache_for: state
),
get_latest_task_run_states=MagicMock(
side_effect=lambda flow_run_id, states: states
),
set_task_run_name=MagicMock(),
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=cloud_client)
)
monkeypatch.setattr(
"prefect.engine.cloud.flow_runner.Client", MagicMock(return_value=cloud_client)
)
yield cloud_client
@pytest.fixture()
def vclient(monkeypatch):
cloud_client = MagicMock(
get_flow_run_info=MagicMock(return_value=MagicMock(state=None)),
set_flow_run_state=MagicMock(),
get_task_run_info=MagicMock(return_value=MagicMock(state=None)),
set_task_run_state=MagicMock(
side_effect=VersionLockMismatchSignal(),
return_value=Running()
# side_effect=lambda task_run_id, version, state, cache_for: state
),
get_latest_task_run_states=MagicMock(
side_effect=lambda flow_run_id, states: states
),
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=cloud_client)
)
monkeypatch.setattr(
"prefect.engine.cloud.flow_runner.Client", MagicMock(return_value=cloud_client)
)
yield cloud_client
def test_task_runner_puts_cloud_in_context(client):
@prefect.task(result=Result())
def whats_in_ctx():
return prefect.context.get("checkpointing")
res = CloudTaskRunner(task=whats_in_ctx).run()
assert res.is_successful()
assert res.result is True
def test_task_runner_calls_client_if_map_index_is_none(client):
task = Task(name="test")
res = CloudTaskRunner(task=task).run()
## assertions
assert client.get_task_run_info.call_count == 1 # called once
assert client.set_task_run_state.call_count == 2 # Pending -> Running -> Success
assert client.get_latest_cached_states.call_count == 0
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert [type(s).__name__ for s in states] == ["Running", "Success"]
assert res.is_successful()
assert states[0].context == dict(tags=[])
assert states[1].context == dict(tags=[])
def test_task_runner_places_task_tags_in_state_context_and_serializes_them(client):
task = Task(name="test", tags=["1", "2", "tag"])
res = CloudTaskRunner(task=task).run()
call_args = [c[1] for c in client.set_task_run_state.call_args_list]
assert call_args[0]["state"].is_running()
assert call_args[1]["state"].is_successful()
assert set(call_args[0]["state"].context["tags"]) == set(["1", "2", "tag"])
assert set(call_args[1]["state"].context["tags"]) == set(["1", "2", "tag"])
def test_task_runner_calls_get_task_run_info_if_map_index_is_not_none(client):
task = Task(name="test")
res = CloudTaskRunner(task=task).run(context={"map_index": 1})
## assertions
assert client.get_task_run_info.call_count == 1
assert client.set_task_run_state.call_count == 2 # Pending -> Running -> Success
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert [type(s).__name__ for s in states] == ["Running", "Success"]
def test_task_runner_sets_mapped_state_prior_to_executor_mapping(client):
upstream_states = {
Edge(Task(), Task(), key="foo", mapped=True): Success(result=[1, 2])
}
with pytest.raises(ENDRUN) as exc:
CloudTaskRunner(task=Task()).check_task_ready_to_map(
state=Pending(), upstream_states=upstream_states
)
## assertions
assert client.get_task_run_info.call_count == 0
assert client.set_task_run_state.call_count == 1 # Pending -> Mapped
assert client.get_latest_cached_states.call_count == 0
last_set_state = client.set_task_run_state.call_args_list[-1][1]["state"]
assert last_set_state.is_mapped()
def test_task_runner_raises_endrun_if_client_cant_communicate_during_state_updates(
monkeypatch,
):
@prefect.task(name="test")
def raise_error():
raise NameError("I don't exist")
get_task_run_info = MagicMock(return_value=MagicMock(state=None))
set_task_run_state = MagicMock(side_effect=SyntaxError)
client = MagicMock(
get_task_run_info=get_task_run_info, set_task_run_state=set_task_run_state
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
## an ENDRUN will cause the TaskRunner to return the most recently computed state
res = CloudTaskRunner(task=raise_error).run(context={"map_index": 1})
assert set_task_run_state.called
assert isinstance(res, ClientFailed)
assert res.state.is_running()
def test_task_runner_queries_for_cached_states_if_task_has_caching(client):
@prefect.task(cache_for=datetime.timedelta(minutes=1), result=PrefectResult())
def cached_task():
return 42
state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
+ datetime.timedelta(days=1),
result=PrefectResult(location="99"),
)
old_state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
- datetime.timedelta(days=1),
result=13,
)
client.get_latest_cached_states = MagicMock(return_value=[state, old_state])
res = CloudTaskRunner(task=cached_task).run()
assert client.get_latest_cached_states.called
assert res.is_successful()
assert res.is_cached()
assert res.result == 99
def test_task_runner_validates_cached_states_if_task_has_caching(client):
@prefect.task(cache_for=datetime.timedelta(minutes=1), result=PrefectResult())
def cached_task():
return 42
state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
- datetime.timedelta(minutes=2),
result=PrefectResult(location="99"),
)
old_state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
- datetime.timedelta(days=1),
result=PrefectResult(location="13"),
)
client.get_latest_cached_states = MagicMock(return_value=[state, old_state])
res = CloudTaskRunner(task=cached_task).run()
assert client.get_latest_cached_states.called
assert res.is_successful()
assert res.is_cached()
assert res.result == 42
def test_task_runner_treats_unfound_files_as_invalid_caches(client, tmpdir):
@prefect.task(cache_for=datetime.timedelta(minutes=1), result=PrefectResult())
def cached_task():
return 42
state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
+ datetime.timedelta(minutes=2),
result=LocalResult(location=str(tmpdir / "made_up_data.prefect")),
)
old_state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
+ datetime.timedelta(days=1),
result=PrefectResult(location="13"),
)
client.get_latest_cached_states = MagicMock(return_value=[state, old_state])
res = CloudTaskRunner(task=cached_task).run()
assert client.get_latest_cached_states.called
assert res.is_successful()
assert res.is_cached()
assert res.result == 13
class TestCheckTaskCached:
def test_reads_result_if_cached_valid(self, client):
result = PrefectResult(location="2")
with pytest.warns(UserWarning):
task = Task(cache_validator=duration_only, result=PrefectResult())
state = Cached(
result=result, cached_result_expiration=pendulum.now("utc").add(minutes=1)
)
client.get_latest_cached_states = MagicMock(return_value=[])
new = CloudTaskRunner(task).check_task_is_cached(
state=state, inputs={"a": PrefectResult(value=1)}
)
assert new is state
assert new.result == 2
def test_reads_result_using_handler_attribute_if_cached_valid(self, client):
class MyResult(Result):
def read(self, *args, **kwargs):
self.value = 53
return self
with pytest.warns(UserWarning):
task = Task(cache_validator=duration_only, result=MyResult())
result = PrefectResult(location="2")
state = Cached(
result=result, cached_result_expiration=pendulum.now("utc").add(minutes=1)
)
client.get_latest_cached_states = MagicMock(return_value=[])
new = CloudTaskRunner(task).check_task_is_cached(
state=state, inputs={"a": Result(1)}
)
assert new is state
assert new.result == 53
def test_reads_result_if_cached_valid_using_task_result(task, client):
class MyResult(Result):
def read(self, *args, **kwargs):
self.value = 53
return self
task = Task(
result=MyResult(),
cache_for=datetime.timedelta(minutes=1),
cache_validator=duration_only,
)
state = Cached(
result=PrefectResult(location="2"),
cached_result_expiration=pendulum.now("utc").add(minutes=1),
)
client.get_latest_cached_states = MagicMock(return_value=[state])
new = CloudTaskRunner(task).check_task_is_cached(
state=Pending(), inputs={"a": Result(1)}
)
assert new is state
assert new.result == 53
def test_state_kwarg_is_prioritized_over_db_caches(self, client):
task = Task(
cache_for=datetime.timedelta(minutes=1),
cache_validator=duration_only,
result=PrefectResult(),
)
state_a = Cached(
result=PrefectResult(location="2"),
cached_result_expiration=pendulum.now("utc").add(minutes=1),
)
state_b = Cached(
result=PrefectResult(location="99"),
cached_result_expiration=pendulum.now("utc").add(minutes=1),
)
client.get_latest_cached_states = MagicMock(return_value=[state_a])
new = CloudTaskRunner(task).check_task_is_cached(
state=state_b, inputs={"a": Result(1)}
)
assert new is state_b
assert new.result == 99
def test_task_runner_validates_cached_state_inputs_if_task_has_caching(
self, client
):
@prefect.task(
cache_for=datetime.timedelta(minutes=1),
cache_validator=all_inputs,
result=PrefectResult(),
)
def cached_task(x):
return 42
dull_state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
+ datetime.timedelta(minutes=2),
result=PrefectResult(location="-1"),
)
state = Cached(
cached_result_expiration=datetime.datetime.utcnow()
+ datetime.timedelta(minutes=2),
result=PrefectResult(location="99"),
hashed_inputs={"x": tokenize(2)},
)
client.get_latest_cached_states = MagicMock(return_value=[dull_state, state])
res = CloudTaskRunner(task=cached_task).check_task_is_cached(
Pending(), inputs={"x": PrefectResult(value=2)}
)
assert client.get_latest_cached_states.called
assert res.is_successful()
assert res.is_cached()
assert res.result == 99
def test_task_runner_raises_endrun_if_client_cant_receive_state_updates(monkeypatch):
task = Task(name="test")
get_task_run_info = MagicMock(side_effect=SyntaxError)
set_task_run_state = MagicMock()
client = MagicMock(
get_task_run_info=get_task_run_info, set_task_run_state=set_task_run_state
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
## an ENDRUN will cause the TaskRunner to return the most recently computed state
res = CloudTaskRunner(task=task).run(context={"map_index": 1})
assert get_task_run_info.called
assert res.is_failed()
assert isinstance(res.result, SyntaxError)
def test_task_runner_raises_endrun_with_correct_state_if_client_cant_receive_state_updates(
monkeypatch,
):
task = Task(name="test")
get_task_run_info = MagicMock(side_effect=SyntaxError)
set_task_run_state = MagicMock()
client = MagicMock(
get_task_run_info=get_task_run_info, set_task_run_state=set_task_run_state
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
## an ENDRUN will cause the TaskRunner to return the most recently computed state
state = Pending(message="unique message", result=42)
res = CloudTaskRunner(task=task).run(state=state, context={"map_index": 1})
assert get_task_run_info.called
assert res is state
@pytest.mark.parametrize(
"state", [Finished, Success, Skipped, Failed, TimedOut, TriggerFailed]
)
def test_task_runner_respects_the_db_state(monkeypatch, state):
task = Task(name="test")
db_state = state("already", result=10)
get_task_run_info = MagicMock(return_value=MagicMock(state=db_state))
set_task_run_state = MagicMock()
client = MagicMock(
get_task_run_info=get_task_run_info, set_task_run_state=set_task_run_state
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
res = CloudTaskRunner(task=task).run(context={"map_index": 1})
## assertions
assert get_task_run_info.call_count == 1 # one time to pull latest state
assert set_task_run_state.call_count == 0 # never needs to update state
assert res == db_state
@pytest.mark.parametrize(
"state", [Finished, Success, Skipped, Failed, TimedOut, TriggerFailed]
)
def test_task_runner_prioritizes_kwarg_states_over_db_states(monkeypatch, state):
task = Task(name="test")
db_state = state("already", result=10)
get_task_run_info = MagicMock(return_value=MagicMock(state=db_state))
set_task_run_state = MagicMock(
side_effect=lambda task_run_id, version, state, cache_for: state
)
client = MagicMock(
get_task_run_info=get_task_run_info, set_task_run_state=set_task_run_state
)
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
res = CloudTaskRunner(task=task).run(
state=Pending("let's do this"), context={"map_index": 1}
)
## assertions
assert get_task_run_info.call_count == 1 # one time to pull latest state
assert set_task_run_state.call_count == 2 # Pending -> Running -> Success
states = [call[1]["state"] for call in set_task_run_state.call_args_list]
assert [type(s).__name__ for s in states] == ["Running", "Success"]
class TestStateResultHandling:
def test_task_runner_handles_outputs_prior_to_setting_state(self, client):
@prefect.task(cache_for=datetime.timedelta(days=1), result=PrefectResult())
def add(x, y):
return x + y
result = PrefectResult(value=1)
assert result.location is None
x_state, y_state = Success(result=result), Success(result=result)
upstream_states = {
Edge(Task(), Task(), key="x"): x_state,
Edge(Task(), Task(), key="y"): y_state,
}
res = CloudTaskRunner(task=add).run(upstream_states=upstream_states)
## assertions
assert client.get_task_run_info.call_count == 1
assert (
client.set_task_run_state.call_count == 3
) # Pending -> Running -> Successful -> Cached
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert states[0].is_running()
assert states[1].is_successful()
assert isinstance(states[2], Cached)
assert states[2].result == 2
def test_task_runner_errors_if_no_result_provided_as_input(self, client):
@prefect.task
def add(x, y):
return x + y
base_state = prefect.serialization.state.StateSchema().load({"type": "Success"})
x_state, y_state = base_state, base_state
upstream_states = {
Edge(Task(), Task(), key="x"): x_state,
Edge(Task(), Task(), key="y"): y_state,
}
res = CloudTaskRunner(task=add).run(upstream_states=upstream_states)
assert res.is_failed()
assert "unsupported operand" in res.message
## assertions
assert client.get_task_run_info.call_count == 1
assert client.set_task_run_state.call_count == 2 # Pending -> Running -> Failed
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert states[0].is_running() # this isn't ideal, it's a little confusing
assert states[1].is_failed()
assert "unsupported operand" in states[1].message
@pytest.mark.parametrize("checkpoint", [True, None])
def test_task_runner_sends_checkpointed_success_states_to_cloud(
self, client, checkpoint
):
@prefect.task(checkpoint=checkpoint, result=PrefectResult())
def add(x, y):
return x + y
x_state, y_state = (
Success(result=PrefectResult(value=1)),
Success(result=PrefectResult(value=1)),
)
upstream_states = {
Edge(Task(), Task(), key="x"): x_state,
Edge(Task(), Task(), key="y"): y_state,
}
res = CloudTaskRunner(task=add).run(upstream_states=upstream_states)
## assertions
assert client.get_task_run_info.call_count == 1
assert (
client.set_task_run_state.call_count == 2
) # Pending -> Running -> Successful
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert states[0].is_running()
assert states[1].is_successful()
assert states[1]._result.location == "2"
def test_task_handlers_handle_retry_signals(client):
def state_handler(t, o, n):
if n.is_failed():
raise prefect.engine.signals.RETRY(
"Will retry.", start_time=pendulum.now("utc").add(days=1)
)
@prefect.task(state_handlers=[state_handler])
def fn():
1 / 0
state = CloudTaskRunner(task=fn).run()
assert state.is_retrying()
assert state.run_count == 1
# to make it run
state.start_time = pendulum.now("utc")
new_state = CloudTaskRunner(task=fn).run(state=state)
assert new_state.is_retrying()
assert new_state.run_count == 2
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert [type(s).__name__ for s in states] == ["Running", "Retrying"] * 2
def test_state_handler_failures_are_handled_appropriately(client, caplog):
def bad(*args, **kwargs):
raise SyntaxError("Syntax Errors are nice because they're so unique")
@prefect.task(on_failure=bad)
def do_nothing():
raise ValueError("This task failed somehow")
res = CloudTaskRunner(task=do_nothing).run()
assert res.is_failed()
assert "SyntaxError" in res.message
assert isinstance(res.result, SyntaxError)
assert client.set_task_run_state.call_count == 2
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert states[0].is_running()
assert states[1].is_failed()
assert isinstance(states[1].result, SyntaxError)
error_logs = [r.message for r in caplog.records if r.levelname == "ERROR"]
assert len(error_logs) >= 2
assert any(
"Exception encountered during task execution" in elog for elog in error_logs
)
assert "Traceback" in caplog.text
assert "SyntaxError" in error_logs[-1]
assert "unique" in error_logs[-1]
assert "state handler" in error_logs[-1]
def test_task_runner_performs_retries_for_short_delays(client):
global_list = []
@prefect.task(max_retries=1, retry_delay=datetime.timedelta(seconds=0))
def noop():
if global_list:
return
else:
global_list.append(0)
raise ValueError("oops")
client.get_task_run_info.side_effect = [
MagicMock(version=i, state=Pending()) for i in range(4, 6)
]
res = CloudTaskRunner(task=noop).run(
context={"task_run_version": 1}, state=None, upstream_states={}
)
## assertions
assert res.is_successful()
assert (
client.get_task_run_info.call_count == 2
) # called once normally and once on the retry
assert (
client.set_task_run_state.call_count == 5
) # Pending -> Running -> Failed -> Retrying -> Running -> Success
versions = [
call[1]["version"]
for call in client.set_task_run_state.call_args_list
if call[1]["version"]
]
assert versions == [4, 5]
def test_task_runner_handles_looping(client):
@prefect.task(result=PrefectResult())
def looper():
if prefect.context.get("task_loop_count", 1) < 3:
raise LOOP(result=prefect.context.get("task_loop_result", 0) + 10)
return prefect.context.get("task_loop_result")
client.get_task_run_info.side_effect = [
MagicMock(version=i, state=Pending()) for i in range(1, 4)
]
res = CloudTaskRunner(task=looper).run(
context={"task_run_version": 1}, state=None, upstream_states={}
)
## assertions
assert res.is_successful()
assert client.get_task_run_info.call_count == 3
assert (
client.set_task_run_state.call_count == 6
) # Pending -> Running -> Looped (1) -> Running -> Looped (2) -> Running -> Success
versions = [
call[1]["version"]
for call in client.set_task_run_state.call_args_list
if call[1]["version"]
]
assert versions == [1, 2, 3]
def test_task_runner_handles_looping_with_no_result(client):
@prefect.task(result=Result())
def looper():
if prefect.context.get("task_loop_count", 1) < 3:
raise LOOP()
return 42
client.get_task_run_info.side_effect = [
MagicMock(version=i, state=Pending()) for i in range(1, 4)
]
res = CloudTaskRunner(task=looper).run(
context={"task_run_version": 1}, state=None, upstream_states={}
)
## assertions
assert res.is_successful()
assert client.get_task_run_info.call_count == 3
assert (
client.set_task_run_state.call_count == 6
) # Pending -> Running -> Looped (1) -> Running -> Looped (2) -> Running -> Success
versions = [
call[1]["version"]
for call in client.set_task_run_state.call_args_list
if call[1]["version"]
]
assert versions == [1, 2, 3]
def test_task_runner_handles_looping_with_retries_with_no_result(client):
# note that looping with retries _requires_ a result handler in Cloud
@prefect.task(
max_retries=1,
retry_delay=datetime.timedelta(seconds=0),
result=PrefectResult(),
)
def looper():
if (
prefect.context.get("task_loop_count") == 2
and prefect.context.get("task_run_count", 1) == 1
):
raise ValueError("Stop")
if prefect.context.get("task_loop_count", 1) < 3:
raise LOOP()
return 42
client.get_task_run_info.side_effect = [
MagicMock(version=i, state=Pending() if i == 0 else Looped(loop_count=i))
for i in range(5)
]
res = CloudTaskRunner(task=looper).run(
context={"task_run_version": 1}, state=None, upstream_states={}
)
## assertions
assert res.is_successful()
assert client.get_task_run_info.call_count == 4
assert (
client.set_task_run_state.call_count == 9
) # Pending -> Running -> Looped (1) -> Running -> Failed -> Retrying -> Running -> Looped(2) -> Running -> Success
versions = [
call[1]["version"]
for call in client.set_task_run_state.call_args_list
if call[1]["version"]
]
assert versions == [1, 2, 3]
def test_task_runner_handles_looping_with_retries(client):
# note that looping _requires_ a result handler in Cloud
@prefect.task(
max_retries=1,
retry_delay=datetime.timedelta(seconds=0),
result=PrefectResult(),
)
def looper():
if (
prefect.context.get("task_loop_count") == 2
and prefect.context.get("task_run_count", 1) == 1
):
raise ValueError("Stop")
if prefect.context.get("task_loop_count", 1) < 3:
raise LOOP(result=prefect.context.get("task_loop_result", 0) + 10)
return prefect.context.get("task_loop_result")
client.get_task_run_info.side_effect = [
MagicMock(version=i, state=Pending() if i == 0 else Looped(loop_count=i))
for i in range(5)
]
res = CloudTaskRunner(task=looper).run(
context={"task_run_version": 1}, state=None, upstream_states={}
)
## assertions
assert res.is_successful()
assert client.get_task_run_info.call_count == 4
assert (
client.set_task_run_state.call_count == 9
) # Pending -> Running -> Looped (1) -> Running -> Failed -> Retrying -> Running -> Looped(2) -> Running -> Success
versions = [
call[1]["version"]
for call in client.set_task_run_state.call_args_list
if call[1]["version"]
]
assert versions == [1, 2, 3]
def test_cloud_task_runner_respects_queued_states_from_cloud(client):
calls = []
def queued_mock(*args, **kwargs):
calls.append(kwargs)
if len(calls) == 1:
return Queued() # immediate start time
else:
return kwargs.get("state")
client.set_task_run_state = queued_mock
@prefect.task
def tagged_task():
pass
res = CloudTaskRunner(task=tagged_task).run(
context={"task_run_version": 1}, state=None, upstream_states={}
)
assert res.is_successful()
assert len(calls) == 3 # Running -> Running -> Success
assert [type(c["state"]).__name__ for c in calls] == [
"Running",
"Running",
"Success",
]
def test_cloud_task_runner_handles_retries_with_queued_states_from_cloud(client):
calls = []
def queued_mock(*args, **kwargs):
calls.append(kwargs)
# first retry attempt will get queued
if len(calls) == 4:
return Queued() # immediate start time
else:
return kwargs.get("state")
client.set_task_run_state = queued_mock
@prefect.task(
max_retries=2, retry_delay=datetime.timedelta(seconds=0), result=PrefectResult()
)
def tagged_task(x):
if prefect.context.get("task_run_count", 1) == 1:
raise ValueError("gimme a sec")
return x
upstream_result = PrefectResult(value=42, location="42")
res = CloudTaskRunner(task=tagged_task).run(
context={"task_run_version": 1},
state=None,
upstream_states={
Edge(Task(), tagged_task, key="x"): Success(result=upstream_result)
},
)
assert res.is_successful()
assert res.result == 42
assert (
len(calls) == 6
) # Running -> Failed -> Retrying -> Queued -> Running -> Success
assert [type(c["state"]).__name__ for c in calls] == [
"Running",
"Failed",
"Retrying",
"Running",
"Running",
"Success",
]
class TestLoadResults:
def test_load_results_from_upstream_reads_results(self, cloud_api):
result = PrefectResult(location="1")
state = Success(result=result)
assert result.value is None
t = Task(result=PrefectResult())
edge = Edge(t, 2, key="x")
new_state, upstreams = CloudTaskRunner(task=Task()).load_results(
state=Pending(), upstream_states={edge: state}
)
assert upstreams[edge].result == 1
def test_load_results_from_upstream_reads_results_using_upstream_handlers(
self, cloud_api
):
class CustomResult(Result):
def read(self, *args, **kwargs):
return "foo-bar-baz".split("-")
state = Success(result=PrefectResult(location="1"))
edge = Edge(Task(result=CustomResult()), 2, key="x")
new_state, upstreams = CloudTaskRunner(task=Task()).load_results(
state=Pending(), upstream_states={edge: state}
)
assert upstreams[edge].result == ["foo", "bar", "baz"]
def test_load_results_from_upstream_reads_secret_results(self, cloud_api):
secret_result = SecretResult(prefect.tasks.secrets.PrefectSecret(name="foo"))
state = Success(result=PrefectResult(location="foo"))
with prefect.context(secrets=dict(foo=42)):
edge = Edge(Task(result=secret_result), 2, key="x")
new_state, upstreams = CloudTaskRunner(task=Task()).load_results(
state=Pending(), upstream_states={edge: state}
)
assert upstreams[edge].result == 42
def test_task_runner_uses_upstream_result_handlers(client):
class MyResult(Result):
def read(self, *args, **kwargs):
self.value = "cool"
return self
def write(self, *args, **kwargs):
return self
@prefect.task(result=PrefectResult())
def t(x):
return x
success = Success(result=PrefectResult(location="1"))
upstream_states = {Edge(Task(result=MyResult()), t, key="x"): success}
state = CloudTaskRunner(task=t).run(upstream_states=upstream_states)
assert state.is_successful()
assert state.result == "cool"
def test_task_runner_doesnt_use_upstream_result_handlers_if_value_present(client):
class MyResult(Result):
def read(self, *args, **kwargs):
self.value = "cool"
return self
def write(self, *args, **kwargs):
return self
@prefect.task(result=PrefectResult())
def t(x):
return x
success = Success(result=PrefectResult(value=1))
upstream_states = {Edge(Task(result=MyResult()), t, key="x"): success}
state = CloudTaskRunner(task=t).run(upstream_states=upstream_states)
assert state.is_successful()
assert state.result == 1
def test_task_runner_gracefully_handles_load_results_failures(client):
class MyResult(Result):
def read(self, *args, **kwargs):
raise TypeError("something is wrong!")
@prefect.task(result=PrefectResult())
def t(x):
return x
success = Success(result=MyResult(location="foo.txt"))
upstream_states = {Edge(Task(result=MyResult()), t, key="x"): success}
state = CloudTaskRunner(task=t).run(upstream_states=upstream_states)
assert state.is_failed()
assert "task results" in state.message
assert client.set_task_run_state.call_count == 1 # Pending -> Failed
states = [call[1]["state"] for call in client.set_task_run_state.call_args_list]
assert [type(s).__name__ for s in states] == ["Failed"]
def test_task_runner_handles_version_lock_error(monkeypatch):
client = MagicMock()
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
client.set_task_run_state.side_effect = VersionLockMismatchSignal()
task = Task(name="test")
runner = CloudTaskRunner(task=task)
# successful state
client.get_task_run_state.return_value = Success()
res = runner.call_runner_target_handlers(Pending(), Running())
assert res.is_successful()
# currently running
client.get_task_run_state.return_value = Running()
with pytest.raises(ENDRUN):
runner.call_runner_target_handlers(Pending(), Running())
# result load error
s = Success()
s.load_result = MagicMock(side_effect=Exception())
client.get_task_run_state.return_value = s
with pytest.raises(ENDRUN):
res = runner.call_runner_target_handlers(Pending(), Running())
def test_task_runner_sets_task_name(monkeypatch, cloud_settings):
client = MagicMock()
monkeypatch.setattr(
"prefect.engine.cloud.task_runner.Client", MagicMock(return_value=client)
)
client.set_task_run_name = MagicMock()
task = Task(name="test", task_run_name="asdf")
runner = CloudTaskRunner(task=task)
runner.task_run_id = "id"