Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for documentation versioning #270

Closed
cicdw opened this issue Oct 12, 2018 · 13 comments
Closed

Allow for documentation versioning #270

cicdw opened this issue Oct 12, 2018 · 13 comments
Labels
Milestone

Comments

@cicdw
Copy link
Member

cicdw commented Oct 12, 2018

Relevant but not necessary for us to do this ourselves: vuejs/vuepress#857

@cicdw cicdw added the docs label Oct 12, 2018
@cicdw
Copy link
Member Author

cicdw commented Oct 25, 2018

I really want to get this out but there are two hurdles I see:

  • we need a place to store old version compiled documentation files (is there someplace on our doc-hosting server we could put this @jlowin ?)
  • we should decide whether to also version the tutorials

@jlowin
Copy link
Member

jlowin commented Oct 25, 2018

Would it be crazy to simply add a version directory inside /docs which simply contains a copy of all documentation files from that version? Basically: cp /docs /docs/versions/0.3.2 (without copying the versions recursively, of course)

@cicdw
Copy link
Member Author

cicdw commented Oct 25, 2018

Hmmm I think it would only be slightly crazy; that could grow to be a lot of baggage (images, etc.) over time and really clog up the repo. But at this exact moment, especially if we just want this ability sooner rather than later, that is totally reasonable in my book.

@jlowin
Copy link
Member

jlowin commented Oct 25, 2018

I have zero expertise in this so it's probably safe to ignore me :)

We can always use git to retrieve the historical docs, so any decision is reversible.

@cicdw
Copy link
Member Author

cicdw commented Oct 26, 2018

I'm leaning towards only versioning the API docs (avoids having to worry about image versioning, etc. for the tutorials) --> what do y'all think @jlowin @joshmeek ?

@joshmeek
Copy link

I would support API doc versioning because it seems like the most frequently changed among the suite. However if features used in tutorials change in breaking ways then those too will need to be updated.

@cicdw
Copy link
Member Author

cicdw commented Oct 26, 2018

Right - updating is one thing, but actually keeping all previous versions of tutorials is another

@joshmeek
Copy link

Hmm good point. How hard is it to enable full support for documentation versioning?

If we went with full documentation versioning (not just API) we could provide some mechanism where a deprecated version of prefect documents exists outside of the repo. Although that then boils down to backwards compatibility.

@cicdw
Copy link
Member Author

cicdw commented Oct 26, 2018

There are two issues with doing full versioning:

  • the UI aspect: making a simple dropdown on the API link in the navbar is very easy; if we versinoined the entire doc suite, how would we expose this in the docs UI? I guess a "Version" navbar link?
  • all images are stored in .vuepress/public and can be referenced without knowing their location; if we versioned everything, we'd also have to figure out how to handle the images

@cicdw
Copy link
Member Author

cicdw commented Oct 26, 2018

Ok so I stand by my claim that it would be "easy" but very messy --> the .vuepress/config.js file controls the display of the sidebar, and we would need to have an explicitly configured sidebar for each API version.....

@cicdw
Copy link
Member Author

cicdw commented Nov 1, 2018

@dylanbhughes do you have any ideas about the best way to do API doc-versioning in vuepress?

@jlowin jlowin added this to the v0.4.0 milestone Nov 4, 2018
@cicdw
Copy link
Member Author

cicdw commented Dec 11, 2018

I just revisited this and it will also require us to maintain a sidebar in our master .vuepress/config.js for every API version... there's just got to be a better way

@jlowin jlowin modified the milestones: v0.4.0, Future Jan 8, 2019
@cicdw cicdw modified the milestones: Future, v0.6.0 Mar 28, 2019
@cicdw
Copy link
Member Author

cicdw commented Mar 28, 2019

@jlowin suggested a possible route forward here: store all the necessary artifacts / files in an appropriate subdirectory of docs/api/versionNUM in github, and then actually use javascript to dynamically create the correct sidebar for that API version link (.vuepress/config.js should be able to execute javascript, after all).

@cicdw cicdw mentioned this issue Mar 29, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants