Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting flow_run_id in local runs breaks slack notifier #2930

Closed
joshmeek opened this issue Jul 8, 2020 · 0 comments · Fixed by #3136
Closed

Setting flow_run_id in local runs breaks slack notifier #2930

joshmeek opened this issue Jul 8, 2020 · 0 comments · Fixed by #3136
Labels
bug Something isn't working

Comments

@joshmeek
Copy link

joshmeek commented Jul 8, 2020

#2868 made some additions to local runs so that targets/results could be templated properly both locally and in runs using a backend API. Setting flow_run_id on local runs here:

flow_run_context.update(
scheduled_start_time=next_run_time,
flow_id=self.name,
flow_run_id=str(uuid.uuid4()),
flow_run_name=str(uuid.uuid4()),
)

breaks the slack_notifier because it has an extra check for a flow_run_id in context.

if prefect.context.get("flow_run_id"):

I think this should be resolved by making the backend functionality of the slack notifier opt-in instead of default when a flow_run_id is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant