Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefect deployment build should not upload data to the block #6376

Closed
3 tasks done
felix-ht opened this issue Aug 11, 2022 · 1 comment
Closed
3 tasks done

prefect deployment build should not upload data to the block #6376

felix-ht opened this issue Aug 11, 2022 · 1 comment
Assignees
Labels
component:deployment Related to workflow deployments enhancement An improvement of an existing feature status:in-progress Someone is working on this, check-in here before beginning new work

Comments

@felix-ht
Copy link

felix-ht commented Aug 11, 2022

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to find a similar request and didn't find it.
  • I searched the Prefect documentation for this feature.

Prefect Version

2.x

Describe the proposed behavior

Prefect deployment build should not upload data to the storage block. Instead this should be done by apply.

prefect deployment build flow/test.py:test -ib s3/some_block
prefect deployment apply hello_world-depolyment.yaml  #updates the flow on prefect an uploads to s3 block

The yaml holds all the required information anyhow.

Describe the current behavior

prefect deployment build flow/test.py:test -ib s3/some_block # uploads to s3
prefect deployment apply hello_world-depolyment.yaml #updates the flow on prefect

This feels very unintuitive - build should not deploy anything.

With the current state it even feels like there is not even a need for two separate commands. As you always have to run apply after build - otherwise you end up with an inconsistent deployment.

Example Use

No response

Additional context

No response

@felix-ht felix-ht added enhancement An improvement of an existing feature status:triage labels Aug 11, 2022
@zanieb zanieb added the component:deployment Related to workflow deployments label Aug 11, 2022
This was referenced Aug 24, 2022
@bunchesofdonald
Copy link
Contributor

Thanks for the idea @felix-ht! I just wanted to let you know that this feature is available as of 2.3.0, you can now pass --skip-upload to the build command to have it skip uploading. The --apply option was added as well which lets you do build and apply at the same time. https://docs.prefect.io/concepts/deployments/

@bunchesofdonald bunchesofdonald added priority:medium status:in-progress Someone is working on this, check-in here before beginning new work and removed status:triage labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:deployment Related to workflow deployments enhancement An improvement of an existing feature status:in-progress Someone is working on this, check-in here before beginning new work
Projects
None yet
Development

No branches or pull requests

5 participants